libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java - Issue 29424615: Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java

Issue 29424615: Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback (Closed)

Patch Set: changed impl for reading file as bytes array, modified test. AndroidFileSystem now does not resolve… Created May 29, 2017, 11:26 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidFileSystemTest.java » ('j') | libadblockplus-android/jni/JniCallbacks.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java

index a300d7c1aa4856fb101b928bef62d20967349fad..974b54da2addaa5e4d8f965ed73a91ca82cecbe3 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java

@@ -17,9 +17,15 @@

package org.adblockplus.libadblockplus;

+import android.util.Log;

+import org.adblockplus.libadblockplus.android.Utils;

public class MockFilterChangeCallback extends FilterChangeCallback

{

- private int timesCalled;

+ private static final String TAG = Utils.getTag(MockFilterChangeCallback.class);

+ private volatile int timesCalled;

public MockFilterChangeCallback(int timesCalled)

{

@@ -34,6 +40,7 @@ public class MockFilterChangeCallback extends FilterChangeCallback

@Override

public void filterChangeCallback(String action, JsValue jsValue)

{

+ Log.d(TAG, "callback: action=" + action + ", jsValue=" + jsValue);

timesCalled++;

}