libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java - Issue 29424615: Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

Issue 29424615: Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback (Closed)

Patch Set: changed impl for reading file as bytes array, modified test. AndroidFileSystem now does not resolve… Created May 29, 2017, 11:26 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java ('k') | libadblockplus-android/jni/Android.mk » ('j') | libadblockplus-android/jni/JniCallbacks.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

index 40d1a24c4e9e12b22c3aeb58a9a515a2b00c482c..644be3cee52ae24266cae27d8df2570def4ea14a 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

@@ -17,6 +17,7 @@

package org.adblockplus.libadblockplus.tests;

+import android.os.SystemClock;

import android.util.Log;

import org.adblockplus.libadblockplus.Filter;

import org.adblockplus.libadblockplus.FilterEngine;

@@ -331,6 +332,12 @@ public class FilterEngineTest extends FilterEngineGenericTest

@Test

public void testSetRemoveFilterChangeCallback()

{

+ // avoid callback with action "load"

+ while (filterEngine.getListedFilters().size() > 0)

+ {

+ filterEngine.getListedFilters().get(0).removeFromList();

+ }

MockFilterChangeCallback mockFilterChangeCallback = new MockFilterChangeCallback(0);

filterEngine.setFilterChangeCallback(mockFilterChangeCallback);