Issue 4872 - Update Adblock Browser for iOS section of ABP privacy policy

[saroyanm, 2017-04-28 10:36:04]

Only one comment we can discuss other from that looks good.

https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html
File pages/privacy.html (right):

https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html#...
pages/privacy.html:189: {{abb-ios-crash-item-1[list item] Bundle identifier,
bundle version and short bundle version string of <fix>Adblock Browser</fix> for
<fix>iOS</fix>. }}
Note: When updating the stringID the translations can be lost in crowdin, this
changes rather small (punctuation and space), not sure if it worth to change the
stringID otherwise we need to inform Tamara about that.

[tamara, 2017-04-28 10:59:46]

On 2017/04/28 10:36:04, saroyanm wrote:
> Only one comment we can discuss other from that looks good.
> 
> https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html
> File pages/privacy.html (right):
> 
>
https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html#...
> pages/privacy.html:189: {{abb-ios-crash-item-1[list item] Bundle identifier,
> bundle version and short bundle version string of <fix>Adblock Browser</fix>
for
> <fix>iOS</fix>. }}
> Note: When updating the stringID the translations can be lost in crowdin, this
> changes rather small (punctuation and space), not sure if it worth to change
the
> stringID otherwise we need to inform Tamara about that.

I'm afraid the translations were already lost in Crowdin after we updated the
whole page (hence why it's displayed only in French and German), so it really
wouldn't make much difference, in my opinion. That string will still have to be
implemented for the second part of the text anyway, so just a bit more of work
shouldn't be a problem.

[saroyanm, 2017-04-28 11:32:21]

On 2017/04/28 10:59:46, tamara wrote:
> On 2017/04/28 10:36:04, saroyanm wrote:
> > Only one comment we can discuss other from that looks good.
> > 
> > https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html
> > File pages/privacy.html (right):
> > 
> >
>
https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html#...
> > pages/privacy.html:189: {{abb-ios-crash-item-1[list item] Bundle identifier,
> > bundle version and short bundle version string of <fix>Adblock Browser</fix>
> for
> > <fix>iOS</fix>. }}
> > Note: When updating the stringID the translations can be lost in crowdin,
this
> > changes rather small (punctuation and space), not sure if it worth to change
> the
> > stringID otherwise we need to inform Tamara about that.
> 
> I'm afraid the translations were already lost in Crowdin after we updated the
> whole page (hence why it's displayed only in French and German), so it really
> wouldn't make much difference, in my opinion. That string will still have to
be
> implemented for the second part of the text anyway, so just a bit more of work
> shouldn't be a problem.

Considering Tamara's comment LGTM