Issue 4777 - Add support for Gradle build

Issue 4777 - Add support for Gradle build

[anton, 2017-04-29 10:23:25]

https://codereview.adblockplus.org/29424711/diff/29424712/.gitignore
File .gitignore (right):

https://codereview.adblockplus.org/29424711/diff/29424712/.gitignore#newcode12
.gitignore:12: .idea/workspace.xml
why not to exclude all ".idea"? there should be nothing related to IDE in the
repo

https://codereview.adblockplus.org/29424711/diff/29424712/.idea/compiler.xml
File .idea/compiler.xml (right):

https://codereview.adblockplus.org/29424711/diff/29424712/.idea/compiler.xml#...
.idea/compiler.xml:1: <?xml version="1.0" encoding="UTF-8"?>
all .idea files should be excluded from the repository (add to both .gitignore
and .hgignore)

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
File adblockplussbrowser/.classpath (right):

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
adblockplussbrowser/.classpath:1: <?xml version="1.0" encoding="UTF-8"?>
should be excluded from the repo

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
File adblockplussbrowser/.project (right):

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
adblockplussbrowser/.project:1: <?xml version="1.0" encoding="UTF-8"?>
should be excluded from the repo

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
File adblockplussbrowser/build.gradle (right):

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
adblockplussbrowser/build.gradle:40: compile
"com.android.support:support-v4:$rootProject.ext.androidSupportLibraryVersion"
won't it conflict with existing jar files in 'libs'?

[diegocarloslima, 2017-04-29 12:03:21]

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
File adblockplussbrowser/build.gradle (right):

https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
adblockplussbrowser/build.gradle:40: compile
"com.android.support:support-v4:$rootProject.ext.androidSupportLibraryVersion"
On 2017/04/29 10:23:25, anton wrote:
> won't it conflict with existing jar files in 'libs'?

No, because the libs folder isn't being used by Gradle. If we ever need to use
the libs folder, we can either use a different name for the libs required only
for Eclipse or just exclude the jars we don't want to be used by Gradle.

[anton, 2017-05-02 05:09:00]

On 2017/04/29 12:03:21, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> File adblockplussbrowser/build.gradle (right):
> 
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> adblockplussbrowser/build.gradle:40: compile
> "com.android.support:support-v4:$rootProject.ext.androidSupportLibraryVersion"
> On 2017/04/29 10:23:25, anton wrote:
> > won't it conflict with existing jar files in 'libs'?
> 
> No, because the libs folder isn't being used by Gradle. If we ever need to use
> the libs folder, we can either use a different name for the libs required only
> for Eclipse or just exclude the jars we don't want to be used by Gradle.

Ok

[diegocarloslima, 2017-05-03 13:53:36]

On 2017/05/02 05:09:00, anton wrote:
> On 2017/04/29 12:03:21, diegocarloslima wrote:
> >
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> > File adblockplussbrowser/build.gradle (right):
> > 
> >
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> > adblockplussbrowser/build.gradle:40: compile
> >
"com.android.support:support-v4:$rootProject.ext.androidSupportLibraryVersion"
> > On 2017/04/29 10:23:25, anton wrote:
> > > won't it conflict with existing jar files in 'libs'?
> > 
> > No, because the libs folder isn't being used by Gradle. If we ever need to
use
> > the libs folder, we can either use a different name for the libs required
only
> > for Eclipse or just exclude the jars we don't want to be used by Gradle.
> 
> Ok

After a discussion with Anton, we decided that the less IDE files in the repo,
the better. So we'll ignore the whole .ignore folder and also the .project and
.classpath files

[anton, 2017-05-03 13:57:13]

On 2017/05/03 13:53:36, diegocarloslima wrote:
> On 2017/05/02 05:09:00, anton wrote:
> > On 2017/04/29 12:03:21, diegocarloslima wrote:
> > >
> >
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> > > File adblockplussbrowser/build.gradle (right):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> > > adblockplussbrowser/build.gradle:40: compile
> > >
> "com.android.support:support-v4:$rootProject.ext.androidSupportLibraryVersion"
> > > On 2017/04/29 10:23:25, anton wrote:
> > > > won't it conflict with existing jar files in 'libs'?
> > > 
> > > No, because the libs folder isn't being used by Gradle. If we ever need to
> use
> > > the libs folder, we can either use a different name for the libs required
> only
> > > for Eclipse or just exclude the jars we don't want to be used by Gradle.
> > 
> > Ok
> 
> After a discussion with Anton, we decided that the less IDE files in the repo,
> the better. So we'll ignore the whole .ignore folder and also the .project and
> .classpath files

I assume it was meant to be "ignore the whole .idea folder". LGTM

[diegocarloslima, 2017-05-03 14:34:31]

On 2017/05/03 13:57:13, anton wrote:
> On 2017/05/03 13:53:36, diegocarloslima wrote:
> > On 2017/05/02 05:09:00, anton wrote:
> > > On 2017/04/29 12:03:21, diegocarloslima wrote:
> > > >
> > >
> >
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> > > > File adblockplussbrowser/build.gradle (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.adblockplus.org/29424711/diff/29424712/adblockplussbrowser...
> > > > adblockplussbrowser/build.gradle:40: compile
> > > >
> >
"com.android.support:support-v4:$rootProject.ext.androidSupportLibraryVersion"
> > > > On 2017/04/29 10:23:25, anton wrote:
> > > > > won't it conflict with existing jar files in 'libs'?
> > > > 
> > > > No, because the libs folder isn't being used by Gradle. If we ever need
to
> > use
> > > > the libs folder, we can either use a different name for the libs
required
> > only
> > > > for Eclipse or just exclude the jars we don't want to be used by Gradle.
> > > 
> > > Ok
> > 
> > After a discussion with Anton, we decided that the less IDE files in the
repo,
> > the better. So we'll ignore the whole .ignore folder and also the .project
and
> > .classpath files
> 
> I assume it was meant to be "ignore the whole .idea folder". LGTM

Yes, it was supposed to be the .idea folder haha

[Felix Dahlke, 2017-05-03 15:20:31]

Moved myself to CC, don't feel I need to review this if Diego had a look, and it
works.