Noissue - use range iterator

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 234 matching lines @@
     onCreated(filterEngine);
     jsEngine->RemoveEventCallback("_init");
   });
 
   // Lock the JS engine while we are loading scripts, no timeouts should fire
   // until we are done.
   const JsContext context(*jsEngine);
 
   // Set the preconfigured prefs
   auto preconfiguredPrefsObject = jsEngine->NewObject();
-  for (FilterEngine::Prefs::const_iterator it = params.preconfiguredPrefs.begin();
-    it != params.preconfiguredPrefs.end(); it++)
+  for (const auto& pref : params.preconfiguredPrefs)
   {
-    preconfiguredPrefsObject.SetProperty(it->first, it->second);
+    preconfiguredPrefsObject.SetProperty(pref.first, pref.second);
   }
   jsEngine->SetGlobalProperty("_preconfiguredPrefs", preconfiguredPrefsObject);
   // Load adblockplus scripts
   for (int i = 0; !jsSources[i].empty(); i += 2)
     jsEngine->Evaluate(jsSources[i + 1], jsSources[i]);
 }
 
 FilterEnginePtr FilterEngine::Create(const JsEnginePtr& jsEngine,
   const FilterEngine::CreationParameters& params)
 {
@@ skipping 71 matching lines @@
 {
   JsValue func = jsEngine->Evaluate("API.getSubscriptionFromUrl");
   return Subscription(func.Call(jsEngine->NewValue(url)));
 }
 
 std::vector<Filter> FilterEngine::GetListedFilters() const
 {
   JsValue func = jsEngine->Evaluate("API.getListedFilters");
   JsValueList values = func.Call().AsList();
   std::vector<Filter> result;
-  for (JsValueList::iterator it = values.begin(); it != values.end(); it++)
-    result.push_back(Filter(std::move(*it)));
+  for (auto& value : values)
+    result.push_back(Filter(std::move(value)));
   return result;
 }
 
 std::vector<Subscription> FilterEngine::GetListedSubscriptions() const
 {
   JsValue func = jsEngine->Evaluate("API.getListedSubscriptions");
   JsValueList values = func.Call().AsList();
   std::vector<Subscription> result;
-  for (JsValueList::iterator it = values.begin(); it != values.end(); it++)
-    result.push_back(Subscription(std::move(*it)));
+  for (auto& value : values)
+    result.push_back(Subscription(std::move(value)));
   return result;
 }
 
 std::vector<Subscription> FilterEngine::FetchAvailableSubscriptions() const
 {
   JsValue func = jsEngine->Evaluate("API.getRecommendedSubscriptions");
   JsValueList values = func.Call().AsList();
   std::vector<Subscription> result;
-  for (JsValueList::iterator it = values.begin(); it != values.end(); it++)
-    result.push_back(Subscription(std::move(*it)));
+  for (auto& value : values)
+    result.push_back(Subscription(std::move(value)));
   return result;
 }
 
 void FilterEngine::SetAAEnabled(bool enabled)
 {
   jsEngine->Evaluate("API.setAASubscriptionEnabled").Call(jsEngine->NewValue(enabled));
 }
 
 bool FilterEngine::IsAAEnabled() const
 {
@@ skipping 227 matching lines @@
     FilterPtr filter = GetWhitelistingFilter(currentUrl, contentTypeMask, parentUrl);
     if (filter)
     {
       return filter;
     }
     currentUrl = parentUrl;
   }
   while (urlIterator != documentUrls.end());
   return FilterPtr();
 }