Issue 5191 - Add Terms of Use to adblockplus.org homepage

includes/index.tmpl

 title=Adblock Plus - Surf the web without annoying ads!
 noheading=True
 localefile=index
 
 {#
  # This file is part of the Adblock Plus website,
  # Copyright (C) 2006-2017 eyeo GmbH
  #
  # Adblock Plus is free software: you can redistribute it and/or modify
  # it under the terms of the GNU General Public License version 3 as
@@ skipping 49 matching lines @@
           <div class="sprite"></div>
           {{"It's free for users and open source (<a href=\"https://www.gnu.org/licenses/gpl.html\">GPLv3</a>)"|translate("gplv3-license")}}
         </li>
         <li id="feature-maxthon" itemprop="featureList">
           <div class="sprite"></div>
           {{"Integrated by default in"|translate("s11")}} <a href="http://www.maxthon.com/" target="_blank">{{"Maxthon Cloud Browser"|translate("s12")}}</a>
         </li>
       </ul>
     </div>
 
+    {% if locale == "en" or has_string("terms-message", "index") %}

[saroyanm, 2017/05/02 09:26:37]

We should check against "defaultlocale" I think instead of the value of
"defaultlocale".
Imagine one day the locale might change into en-US ?

[saroyanm, 2017/05/02 09:26:37]

This is wrong, the string can be translated while the page is not.
We should check if the page is translated to current language or not.

Probably similar to what does linkify.

[juliandoucette, 2017/05/02 10:22:12]

I agree. But I don't know how to do this without changing CMS core.

Do you have any ideas Jon?

[juliandoucette, 2017/05/02 10:22:12]

Acknowledged.

[juliandoucette, 2017/05/02 10:32:01]

Done.

[juliandoucette, 2017/05/02 10:32:01]

Detail: I think that we have to check if the message AND the page is translated

+      <p class="terms-message">
+        {{ "By clicking the Agree and Install button below, you agree to our <a href='terms'>Terms of Use</a>." | translate("terms-message", "Terms of use message") }}
+      </p>
+    {% endif %}
+
     <h3 class="edge-message">
       {{"Adblock Plus for Microsoft Edge requires Windows 10 Anniversary Update"|translate("edge-message")}}
     </h3>
 
     <div id="install">
-      <a class="install-button" href="https://update.adblockplus.org/latest/adblockplusfirefox.xpi" id="install-firefox">{{"Install for Firefox"|translate("s13")}}</a>
-      <a class="install-button" href="https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" id="install-chrome" onclick="chrome.webstore.install(); return false;">{{"Install for Chrome"|translate("s14")}}</a>
-      <a class="install-button" href="https://addons.opera.com/extensions/details/opera-adblock/?display=en-US" id="install-opera">{{"Install for Opera"|translate("s15")}}</a>
-      <a class="install-button" href="android-install" id="install-android">{{"Install for Android"|translate("s16")}}</a>
-      <a class="install-button" href="https://update.adblockplus.org/latest/adblockplusie.exe" id="install-internet-explorer">{{"Install for Internet Explorer"|translate("s17")}}</a>
-      <a class="install-button" href="https://update.adblockplus.org/latest/adblockplussafari.safariextz" id="install-safari">{{"Install for Safari"|translate("s18")}}</a>
-      <a class="install-button" href="https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" id="install-yandex-browser" onclick="chrome.webstore.install(); return false;">{{"Install for Yandex Browser"|translate("s19")}}</a>
-      <a class="install-button" href="ms-windows-store://pdp/?ProductId=9nblggh4r9nz" id="install-edge">{{"Install for Microsoft Edge"|translate("install-edge")}}</a>
+      {% for platform_id in platforms %}
+        {% set platform = platforms[platform_id] %}
+        <a
+          id="install-{{ platform_id }}"
+          class="install-button"
+          {% if platform_id in ('chrome', 'yandex-browser') %}
+            onclick="chrome.webstore.install(); return false;"
+          {% endif %}
+          href="{{ platform.href }}">
+          {% if locale == "en" or has_string(("agree-install-%s" % platform_id), "index") %}
+            {{ ("Agree and Install for <fix>%s</fix>" % platform.label) | translate(("agree-install-%s" % platform_id), "button label") }}
+          {% else %}
+            {{ ("Install for <fix>%s</fix>" % platform.label) | translate(("install-%s" % platform_id), "button label") }}
+          {% endif %}
+        </a>
+      {% endfor %}
     </div>
 
     <div id="other-platform">
         <div>{{"Download Adblock Plus for another platform"|translate("other-platform")}}</div>
         <ul>
           <li>
             <a class="sprite" href="firefox" id="platform-firefox" title="{{"Adblock Plus for Firefox"|translate("s20")}}"></a>
           </li>
           <li>
             <a class="sprite" href="chrome" id="platform-chrome" title="{{"Adblock Plus for Chrome"|translate("s21")}}"></a>
@@ skipping 269 matching lines @@
       <h2>{{"Be notified when Adblock Plus for Microsoft Edge is available!"|translate("abp-for-edge-be-notified")}}</h2>
 
       <p>
         {{"Microsoft Edge <a href='https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6508820-javascript-browser-extensions'>does not yet support extensions</a>. However, you can be sure that a version of Adblock Plus for Microsoft Edge will be released as soon as possible. While you're waiting, you may want to try the latest version of Adblock Plus for Internet Explorer."|translate("ms-edge-description")}}
       </p>
     </div>
   </div>
 </section>
 
 <script src="/js/index.js"></script>