Issue 5137 - [emscripten] Added basic filter storage implementation

compiled/storage/FilterStorage.h

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#pragma once
+
+#include "../subscription/Subscription.h"
+#include "../bindings/runtime.h"
+
+class FilterStorage
+{
+private:
+  std::vector<SubscriptionPtr> mSubscriptions;
+  static FilterStorage* mInstance;
+
+public:
+  static BINDINGS_EXPORTED FilterStorage* GetInstance()
+  {
+    return mInstance;
+  }
+  unsigned int BINDINGS_EXPORTED GetSubscriptionCount() const;

[hub, 2017/08/22 13:14:14]

Line 30 you put the BINDINGS_EXPORTED before the return type. Here you put it
after.
Also in other source files, it is sometime before, sometime after.

Emscripten documentation show it after the return time (EMSCRIPTEN_KEEPALIVE
which is what BINDINGS_EXPORTED is #defined to)

[Wladimir Palant, 2017/08/31 11:32:36]

Done, it's consistent here now.
Filed https://issues.adblockplus.org/ticket/5604 on this.

+  Subscription* BINDINGS_EXPORTED SubscriptionAt(unsigned int index) const;
+  int BINDINGS_EXPORTED IndexOfSubscription(const Subscription* subscription) const;
+  Subscription* BINDINGS_EXPORTED GetSubscriptionForFilter(
+        const Filter* filter);
+  bool BINDINGS_EXPORTED AddSubscription(Subscription* subscription);
+  bool BINDINGS_EXPORTED RemoveSubscription(Subscription* subscription);
+  bool BINDINGS_EXPORTED MoveSubscription(Subscription* subscription,
+      const Subscription* insertBefore);
+};