Issue 5137 - [emscripten] Added basic filter storage implementation

test/filterStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2017 eyeo GmbH
+ * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 44 matching lines @@
 {
   let subscription1 = Subscription.fromURL("http://test1/");
   let subscription2 = Subscription.fromURL("http://test2/");
   test.ok(!subscription1.listed, "First subscription not listed");
   test.ok(!subscription2.listed, "Second subscription not listed");
 
   let changes = [];
   function listener(action, subscription)
   {
     if (action.indexOf("subscription.") == 0)
       changes.push(action + " " + subscription.url);

[sergei, 2017/05/08 10:54:39]

Is there any reason to not use arrays, changes.push([action,
subscription.url]);?

[Wladimir Palant, 2017/05/08 12:55:41]

This is code from the master branch adapted. But the reason is mostly: it's
easier to write tests, test.deepEqual(changes, ["subscription.added foo"]) is
easier to write and more readable than test.deepEqual(changes,
[["subscription.added", "foo"]]) - particularly once you get multiple changes.

   }
   FilterNotifier.addListener(listener);
 
   compareSubscriptionList(test, "Initial state", []);
   test.deepEqual(changes, [], "Received changes");
 
   changes = [];
   FilterStorage.addSubscription(subscription1);
   compareSubscriptionList(test, "Adding first subscription", [subscription1]);
   test.deepEqual(changes, ["subscription.added http://test1/"], "Received changes");
@@ skipping 166 matching lines @@
     filter.delete();
     subscription.delete();
   }
 
   {
     let subscription = Subscription.fromURL("~other");
     FilterStorage.addSubscription(subscription);
     subscription.delete();
   }
 
+  test.deepEqual(Array.from(FilterStorage.subscriptions, s => s.isGeneric()),
+      [false, false, true], "SpecialSubscription.isGeneric() result");
+
   changes = [];
   addFilter("foo##bar");
   compareFiltersList(test, "Adding hiding rule", [["foo"], ["@@bar", "foo##bar"], []]);
   test.deepEqual(changes, ["filter.added foo##bar 1 1"], "Received changes");
 
   changes = [];
   addFilter("foo#@#bar");
   compareFiltersList(test, "Adding hiding exception", [["foo"], ["@@bar", "foo##bar", "foo#@#bar"], []]);
   test.deepEqual(changes, ["filter.added foo#@#bar 1 2"], "Received changes");
 
@@ skipping 16 matching lines @@
   changes = [];
   addFilter("foo");
   compareFiltersList(test, "Adding filter already in a disabled subscription", [["foo"], ["@@bar", "foo##bar", "foo#@#bar"], ["!foobar", "foo"]]);
   test.deepEqual(changes, ["filter.added foo 2 1"], "Received changes");
 
   changes = [];
   removeFilter("foo");
   compareFiltersList(test, "Removing filter", [[], ["@@bar", "foo##bar", "foo#@#bar"], ["!foobar"]]);
   test.deepEqual(changes, [
     "filter.removed foo 0 0",
-    "filter.removed foo 2 1",
+    "filter.removed foo 2 1"
   ], "Received changes");
 
   changes = [];
   removeFilter("foo");
   compareFiltersList(test, "Removing unknown filter", [[], ["@@bar", "foo##bar", "foo#@#bar"], ["!foobar"]]);
   test.deepEqual(changes, [], "Received changes");
 
   test.done();
 };