Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/storage/FilterStorage.h

Issue 29426559: Issue 5137 - [emscripten] Added basic filter storage implementation (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Rebased, updated copyright year Created Aug. 22, 2017, 11:03 a.m.
Right Patch Set: Fixed bogus assert Created Aug. 31, 2017, 12:44 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/library.js ('k') | compiled/storage/FilterStorage.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #pragma once 18 #pragma once
19 19
20 #include "../subscription/Subscription.h" 20 #include "../subscription/Subscription.h"
21 #include "../bindings/runtime.h" 21 #include "../bindings/runtime.h"
22 22
23 class FilterStorage 23 class FilterStorage
24 { 24 {
25 public:
26 typedef std::vector<SubscriptionPtr> Subscriptions;
27
25 private: 28 private:
26 std::vector<SubscriptionPtr> mSubscriptions; 29 Subscriptions mSubscriptions;
27 static FilterStorage* mInstance; 30 static FilterStorage* mInstance;
28 31
29 public: 32 public:
30 static BINDINGS_EXPORTED FilterStorage* GetInstance() 33 static FilterStorage* BINDINGS_EXPORTED GetInstance()
31 { 34 {
32 return mInstance; 35 return mInstance;
33 } 36 }
34 unsigned int BINDINGS_EXPORTED GetSubscriptionCount() const; 37 Subscriptions::size_type BINDINGS_EXPORTED GetSubscriptionCount() const;
hub 2017/08/22 13:14:14 Line 30 you put the BINDINGS_EXPORTED before the r
Wladimir Palant 2017/08/31 11:32:36 Done, it's consistent here now.
35 Subscription* BINDINGS_EXPORTED SubscriptionAt(unsigned int index) const; 38 Subscription* BINDINGS_EXPORTED SubscriptionAt(
36 int BINDINGS_EXPORTED IndexOfSubscription(const Subscription* subscription) co nst; 39 Subscriptions::size_type index) const;
40 int BINDINGS_EXPORTED IndexOfSubscription(
41 const Subscription* subscription) const;
37 Subscription* BINDINGS_EXPORTED GetSubscriptionForFilter( 42 Subscription* BINDINGS_EXPORTED GetSubscriptionForFilter(
38 const Filter* filter); 43 const Filter* filter) const;
39 bool BINDINGS_EXPORTED AddSubscription(Subscription* subscription); 44 bool BINDINGS_EXPORTED AddSubscription(Subscription* subscription);
40 bool BINDINGS_EXPORTED RemoveSubscription(Subscription* subscription); 45 bool BINDINGS_EXPORTED RemoveSubscription(Subscription* subscription);
41 bool BINDINGS_EXPORTED MoveSubscription(Subscription* subscription, 46 bool BINDINGS_EXPORTED MoveSubscription(Subscription* subscription,
42 const Subscription* insertBefore); 47 const Subscription* insertBefore);
43 }; 48 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld