compiled/subscription/Subscription.cpp - Issue 29426559: Issue 5137 - [emscripten] Added basic filter storage implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/subscription/Subscription.cpp

Issue 29426559: Issue 5137 - [emscripten] Added basic filter storage implementation (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Fixed bogus assert Created Aug. 31, 2017, 12:44 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: compiled/subscription/Subscription.cpp

===================================================================

--- a/compiled/subscription/Subscription.cpp

+++ b/compiled/subscription/Subscription.cpp

@@ -34,28 +34,28 @@ Subscription::Subscription(Type type, co

annotate_address(this, "Subscription");

}

Subscription::~Subscription()

{

knownSubscriptions.erase(mID);

}

-Filter* Subscription::FilterAt(unsigned index)

+Filter* Subscription::FilterAt(Subscription::Filters::size_type index)

{

if (index >= mFilters.size())

return nullptr;

FilterPtr result(mFilters[index]);

return result.release();

}

int Subscription::IndexOfFilter(Filter* filter)

{

- for (unsigned i = 0; i < mFilters.size(); i++)

+ for (Filters::size_type i = 0; i < mFilters.size(); i++)

if (mFilters[i] == filter)

return i;

return -1;

}

OwnedString Subscription::Serialize() const

{

OwnedString result(u"[Subscription]\nurl="_str);