Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29427555: Issue 5188 - Drops Aurora builds from get_browser_versions.py (Closed)

Created:
May 2, 2017, 5:22 a.m. by Jon Sonesen
Modified:
May 4, 2017, 10:11 a.m.
Reviewers:
saroyanm
CC:
Vasily Kuznetsov, juliandoucette, Fred
Visibility:
Public.

Description

Issue 5188 - Drops Aurora builds from get_browser_versions.py

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M globals/get_browser_versions.py View 2 chunks +0 lines, -2 lines 2 comments Download

Messages

Total messages: 4
Jon Sonesen
May 2, 2017, 5:22 a.m. (2017-05-02 05:22:51 UTC) #1
Jon Sonesen
Perhaps the commit message needs to be more accurate
May 2, 2017, 5:24 a.m. (2017-05-02 05:24:36 UTC) #2
saroyanm
Just a small question. https://codereview.adblockplus.org/29427555/diff/29427556/globals/get_browser_versions.py File globals/get_browser_versions.py (left): https://codereview.adblockplus.org/29427555/diff/29427556/globals/get_browser_versions.py#oldcode60 globals/get_browser_versions.py:60: versions['FIREFOX_AURORA'], Why are we removing ...
May 2, 2017, 12:39 p.m. (2017-05-02 12:39:22 UTC) #3
saroyanm
May 2, 2017, 12:40 p.m. (2017-05-02 12:40:20 UTC) #4
LGTM

https://codereview.adblockplus.org/29427555/diff/29427556/globals/get_browser...
File globals/get_browser_versions.py (left):

https://codereview.adblockplus.org/29427555/diff/29427556/globals/get_browser...
globals/get_browser_versions.py:60: versions['FIREFOX_AURORA'],
On 2017/05/02 12:39:22, saroyanm wrote:
> Why are we removing AURORA ?
> 
> I thought the issue was because of Seamonkey testing version only ?

Nevermind, saw the updated discussion.

Powered by Google App Engine
This is Rietveld