Noissue - Configure discourse containers to use smtp on the host system

modules/discourse_docker/manifests/init.pp

 # == Class: discourse_docker
 #
 # Depends on module docker (for now)
 #
 # == Parameters:
 
 # [*domain*]
 #  Set the domain (hostname) for the site. This will be used in both nginx and discourse settings.
 #
 # [*certificate*]
@@ skipping 34 matching lines @@
 #     }
 #   }
 #
 class discourse_docker(
   $domain,
   $certificate = hiera('discourse_docker::certificate', undef),
   $private_key = hiera('discourse_docker::private_key', undef),
   $site_settings = hiera('discourse_docker::site_settings', {}),
   $is_default = hiera('discourse_docker::is_default', false),
   $admins = hiera('discourse_docker::admins', []),
-  $smtp_host = hiera('discourse_docker::smtp_host', undef),

[mathias, 2017/07/07 19:45:43]

Since the template does not place any conditional around the use of this
parameter it should default to something more useful than undef.

[f.nicolaisen, 2017/07/10 08:29:08]

We could use 172.17.0.1 as configured in the hiera examples. This will work in
current vanilla docker containers, but it's an anti-pattern.

Alternatively, I can raise an error if the smtp_host is not explicitly provided.


What do you think?

[mathias, 2017/07/10 08:32:42]

Why not use the formerly hard-coded DISCOURSE_SMTP_ADDRESS value: localhost?

[f.nicolaisen, 2017/07/10 08:39:44]

There is no smtp service on localhost. The container has no postfix installed.

+  $smtp_host = hiera('discourse_docker::smtp_host', '172.17.0.1'),
   $google_oauth2_client_id = hiera('discourse_docker::google_oauth2_client_id', 'undef'),
   $google_oauth2_client_secret = hiera('discourse_docker::google_oauth2_client_secret', 'undef'),
 ) {
 
   include stdlib
 
   package {'git':
     ensure => present,
   }
 
   file {'/var/discourse':
     ensure => directory,
-    mode => 755,
+    mode => '755',
     owner => root,
     group => root
   }
 
   exec {'fetch-discourse-docker':
     command => "git clone https://github.com/discourse/discourse_docker.git /var/discourse",
     path => ["/usr/bin/", "/bin/"],
     user => root,
     timeout => 0,
     require => [Package['git'], File['/var/discourse']],
     unless => "test -d /var/discourse/.git"
   }
 
   file {'/var/discourse/containers/app.yml':
     ensure => file,
-    mode => 600,
+    mode => '600',
     owner => root,
     group => root,
     content => template('discourse_docker/app.yml.erb'),
     require => Class['docker'],
   }
 
   exec {'rebuild':
     command => '/var/discourse/launcher rebuild app --skip-prereqs',
     user => root,
     subscribe => File['/var/discourse/containers/app.yml'],
@@ skipping 14 matching lines @@
 
   nginx::hostconfig {$domain:
     source => "puppet:///modules/discourse_docker/site.conf",
     certificate => $certificate,
     private_key => $private_key,
     is_default => $is_default,
     log => "access_log_intraforum"
   }
 }