Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29428650: Issue 5180 - introduce asynchronous web request (Closed)

Created:
May 3, 2017, 2:13 p.m. by sergei
Modified:
May 8, 2017, 11:09 a.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

#depends on https://codereview.adblockplus.org/29428624/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -211 lines) Patch
M include/AdblockPlus/DefaultWebRequest.h View 1 chunk +12 lines, -1 line 0 comments Download
A + include/AdblockPlus/IWebRequest.h View 3 chunks +19 lines, -14 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 7 chunks +17 lines, -6 lines 0 comments Download
M include/AdblockPlus/WebRequest.h View 1 chunk +1 line, -67 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A + src/DefaultWebRequest.cpp View 1 chunk +21 lines, -4 lines 0 comments Download
M src/DefaultWebRequestCurl.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M src/DefaultWebRequestDummy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/DefaultWebRequestWinInet.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M src/JsEngine.cpp View 3 chunks +11 lines, -10 lines 0 comments Download
M src/WebRequestJsObject.cpp View 1 chunk +64 lines, -59 lines 0 comments Download
M test/BaseJsTest.h View 2 chunks +8 lines, -3 lines 0 comments Download
M test/BaseJsTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M test/FilterEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/UpdateCheck.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M test/WebRequest.cpp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2
sergei
May 3, 2017, 2:24 p.m. (2017-05-03 14:24:45 UTC) #1
hub
May 3, 2017, 5:17 p.m. (2017-05-03 17:17:56 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld