Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29429555: Noissue - updated to libadblockplus revision dca8df9af1a7 (Closed)

Created:
May 4, 2017, 5:08 a.m. by anton
Modified:
May 10, 2017, 6:39 a.m.
Reviewers:
sergei, diegocarloslima
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - updated to libadblockplus revision dca8df9af1a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -106 lines) Patch
M android_armeabi-v7a/libadblockplus.a View Binary file 0 comments Download
M android_armeabi-v7a/libv8_base.a View Binary file 0 comments Download
M android_armeabi-v7a/libv8_snapshot.a View Binary file 0 comments Download
M android_x86/libadblockplus.a View Binary file 0 comments Download
M android_x86/libv8_base.a View Binary file 0 comments Download
M android_x86/libv8_snapshot.a View Binary file 0 comments Download
M include/AdblockPlus/DefaultFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M include/AdblockPlus/FileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M include/AdblockPlus/FilterEngine.h View 13 chunks +68 lines, -38 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 15 chunks +60 lines, -50 lines 0 comments Download
M include/AdblockPlus/JsValue.h View 6 chunks +16 lines, -13 lines 0 comments Download
M include/AdblockPlus/Notification.h View 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 4
anton
It'a first push for the ticket (as libadblockplus-android requires updated libadblockplus-binaries)
May 4, 2017, 5:10 a.m. (2017-05-04 05:10:39 UTC) #1
sergei
LGTM
May 4, 2017, 7:39 a.m. (2017-05-04 07:39:18 UTC) #2
sergei
I think it should be rebased.
May 8, 2017, 8:41 a.m. (2017-05-08 08:41:36 UTC) #3
diegocarloslima
May 8, 2017, 9:53 p.m. (2017-05-08 21:53:08 UTC) #4
On 2017/05/08 08:41:36, sergei wrote:
> I think it should be rebased.

LGTM

Powered by Google App Engine
This is Rietveld