sitescripts/hg/bin/irchook.py - Issue 29430555: Issue 5212 - IRC hook should report bookmarked branches

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: sitescripts/hg/bin/irchook.py

Issue 29430555: Issue 5212 - IRC hook should report bookmarked branches (Closed) Base URL: https://hg.adblockplus.org/sitescripts/

Patch Set: Created May 5, 2017, 8:44 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 import os	1 import os

2 import subprocess	2 import subprocess

3 import pipes	3 import pipes

4	4

5 from sitescripts.utils import get_config	5 from sitescripts.utils import get_config

6	6

7	7

8 def hook(ui, repo, node=None, **kwargs):	8 def hook(ui, repo, node=None, **kwargs):

9 ctx = repo[node]	9 ctx = repo[node]

	10 branches = ctx.bookmarks()
	Vasily Kuznetsov 2017/05/05 09:23:08 I wonder if we could give a better name to this va I wonder if we could give a better name to this variable. `branches` seems a bit confusing, especially on the next line where we're dealing with the actual branch. Maybe we could just call it `bookmarks` (and consider that adding a branch name to the list called `bookmarks` is a lesser confusion :). Or maybe you can think of a better name -- nothing good comes to mind and I think it's not really worth it to think more of this... What do you think? Wladimir Palant 2017/05/05 09:50:24 Let's go with commmit_identifiers. Show quoted text On 2017/05/05 09:23:08, Vasily Kuznetsov wrote: > I wonder if we could give a better name to this variable. `branches` seems a bit > confusing, especially on the next line where we're dealing with the actual > branch. Maybe we could just call it `bookmarks` (and consider that adding a > branch name to the list called `bookmarks` is a lesser confusion :). Or maybe > you can think of a better name -- nothing good comes to mind and I think it's > not really worth it to think more of this... > > What do you think? Let's go with commmit_identifiers. Vasily Kuznetsov 2017/05/05 09:57:33 I like this. Show quoted text On 2017/05/05 09:50:24, Wladimir Palant wrote: > On 2017/05/05 09:23:08, Vasily Kuznetsov wrote: > > I wonder if we could give a better name to this variable. `branches` seems a > bit > > confusing, especially on the next line where we're dealing with the actual > > branch. Maybe we could just call it `bookmarks` (and consider that adding a > > branch name to the list called `bookmarks` is a lesser confusion :). Or maybe > > you can think of a better name -- nothing good comes to mind and I think it's > > not really worth it to think more of this... > > > > What do you think? > > Let's go with commmit_identifiers. I like this.
	11 if len(branches) == 0 or ctx.branch() != 'default':
	Vasily Kuznetsov 2017/05/05 09:23:08 Since branches is a list we could just write `not Since branches is a list we could just write `not branches` instead of `len(branches) == 0`. Wladimir Palant 2017/05/05 09:50:24 Done. Show quoted text On 2017/05/05 09:23:08, Vasily Kuznetsov wrote: > Since branches is a list we could just write `not branches` instead of > `len(branches) == 0`. Done.
	12 branches.append(ctx.branch())

10 remote = [get_config().get('irchook', 'remote_command'),	13 remote = [get_config().get('irchook', 'remote_command'),

11 os.path.basename(repo.root), str(ctx.branch()), str(ctx.user()),	14 os.path.basename(repo.root), ','.join(branches), str(ctx.user()),

12 str(ctx), str(ctx.description())]	15 str(ctx), str(ctx.description())]

13 remote = ' '.join(map(lambda s: pipes.quote(s), remote))	16 remote = ' '.join(map(lambda s: pipes.quote(s), remote))

14	17

15 command = ['ssh', get_config().get('irchook', 'remote_host'), remote]	18 command = ['ssh', get_config().get('irchook', 'remote_host'), remote]

16 subprocess.call(command)	19 subprocess.call(command)

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »