Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1268)

Issue 29430593: Issue 5192 - Add notification for users without Samsung Internet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by jens
Modified:
2 years, 2 months ago
Reviewers:
diegocarloslima
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 5192 - Add notification for users without Samsung Internet

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed CDATA section from string resource #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M adblockplussbrowser/res/values/strings.xml View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
jens
2 years, 2 months ago (2017-05-05 15:21:42 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29430593/diff/29430594/adblockplussbrowser/res/values/strings.xml File adblockplussbrowser/res/values/strings.xml (right): https://codereview.adblockplus.org/29430593/diff/29430594/adblockplussbrowser/res/values/strings.xml#newcode24 adblockplussbrowser/res/values/strings.xml:24: <string name="sbrowser_dialog_message"><![CDATA[Before you can use Adblock Plus, you must ...
2 years, 2 months ago (2017-05-05 17:46:25 UTC) #2
jens
https://codereview.adblockplus.org/29430593/diff/29430594/adblockplussbrowser/res/values/strings.xml File adblockplussbrowser/res/values/strings.xml (right): https://codereview.adblockplus.org/29430593/diff/29430594/adblockplussbrowser/res/values/strings.xml#newcode24 adblockplussbrowser/res/values/strings.xml:24: <string name="sbrowser_dialog_message"><![CDATA[Before you can use Adblock Plus, you must ...
2 years, 2 months ago (2017-05-09 13:50:27 UTC) #3
diegocarloslima
2 years, 2 months ago (2017-05-09 13:53:23 UTC) #4
On 2017/05/09 13:50:27, jens wrote:
>
https://codereview.adblockplus.org/29430593/diff/29430594/adblockplussbrowser...
> File adblockplussbrowser/res/values/strings.xml (right):
> 
>
https://codereview.adblockplus.org/29430593/diff/29430594/adblockplussbrowser...
> adblockplussbrowser/res/values/strings.xml:24: <string
> name="sbrowser_dialog_message"><![CDATA[Before you can use Adblock Plus, you
> must install Samsung Internet 4.0 or above.]]></string>
> On 2017/05/05 17:46:25, diegocarloslima wrote:
> > Since the html tags were removed, we can remove the CDATA section
> 
> Acknowledged.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5