Issue 5193 - Apply Samsung Internet UI changes to the frist run slide

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 21 matching lines @@
 import android.os.Bundle;
 import android.preference.PreferenceActivity;
 import android.preference.PreferenceManager;
 import android.text.Html;
 import android.util.Log;
 
 public class MainPreferences extends PreferenceActivity implements
     EngineService.OnEngineCreatedCallback, SharedPreferences.OnSharedPreferenceChangeListener
 {
   private static final String TAG = MainPreferences.class.getSimpleName();
-  public static final String SBROWSER_APP_ID = "com.sec.android.app.sbrowser";

[diegocarloslima, 2017/05/05 17:44:11]

I think it will be better to move this field to Engine class, once it is being
used there. The common purpose field are usually there.

[jens, 2017/05/09 09:44:45]

Acknowledged.

   private Engine engine = null;
   private Dialog dialog;
   private int dialogTitleResId;
 
   private SharedPreferences getSharedPreferences()
   {
     return PreferenceManager.getDefaultSharedPreferences(this.getApplicationContext());
   }
 
   @Override
@@ skipping 66 matching lines @@
           .setTitle(this.dialogTitleResId)
           .setMessage(Html.fromHtml(getString(R.string.sbrowser_dialog_message)))
           .setNeutralButton(R.string.sbrowser_dialog_button, new OnClickListener()
           {
             @Override
             public void onClick(DialogInterface dialog, int which)
             {
               try
               {
                 startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id="
-                    + SBROWSER_APP_ID)));
+                    + Engine.SBROWSER_APP_ID)));
               }
               catch (final Throwable t)
               {
                 startActivity(new Intent(Intent.ACTION_VIEW, Uri
-                    .parse("https://play.google.com/store/apps/details?id=" + SBROWSER_APP_ID)));
+                    .parse("https://play.google.com/store/apps/details?id=" + Engine.SBROWSER_APP_ID)));
               }
             }
           }).create();
       this.dialog.show();
     }
     else
     {
       this.checkAAStatusAndProceed();
     }
   }
@@ skipping 85 matching lines @@
     }
     else if (this.getString(R.string.key_application_activated).equals(key))
     {
       if (this.dialogTitleResId == R.string.setup_dialog_title)
       {
         this.dismissDialog();
       }
     }
   }
 }