Noissue - Consider Mercurial repository as absent without the .hg/hgrc file

modules/web/manifests/server.pp

 class web::server(
     $vhost,
     $repository,
     $certificate = hiera('web::server::certificate', 'undef'),
     $private_key = hiera('web::server::private_key', 'undef'),
     $is_default = false,
     $aliases = undef,
     $custom_config = undef,
     $multiplexer_locations = undef,
     $geoip = false,
@@ skipping 84 matching lines @@
     comment => 'Web content owner',
     home => '/home/www',
     managehome => true,
   }
 
   exec {"fetch_cms":
     command => "hg clone https://hg.adblockplus.org/cms/ /opt/cms",
     path => ["/usr/bin/", "/bin/"],
     require => Package['mercurial'],
     timeout => 0,
-    onlyif => "test ! -d /opt/cms",
+    onlyif => "test ! -e /opt/cms/.hg/hgrc",

[mathias, 2017/05/05 18:29:18]

You sure this works if the directory previously exists after i.e. an interrupted
clone? Doesn't Mercurial complain about not being able to clone into an existing
non-empty directory? And Please just use attribute creates instead of attribute
onlyif.

[f.lopez, 2017/05/05 19:08:54]

Yeah, the problem I found was that when it timed out the directory was created
but it was empty, so there was not another attempt, if the .hg folder is
created, the hgrc is created as well with the source of the repository, which
leads to a pull instead of aclone, even if the clone was corrupted, the pull
should fix that the next time, which can be a second provisioning

   }
 
   exec {"fetch_repo":
     command => "hg clone -U https://hg.adblockplus.org/${repository} /home/www/${repository}",
     path => ["/usr/bin/", "/bin/"],
     require => Package['mercurial'],
     user => www,
     timeout => 0,
-    onlyif => "test ! -d /home/www/${repository}",
+    onlyif => "test ! -e /home/www/${repository}/.hg/hgrc",
   }
 
   file {'/var/www':
     ensure => directory,
     mode => 755,
   }
 
   file {[
     "/var/cache/$repository",
     "/var/www/$vhost",
@@ skipping 11 matching lines @@
   }
 
   cron {'update_repo':
     ensure => present,
     command => "hg pull -q -R /home/www/${repository} && python -m cms.bin.generate_static_pages /home/www/${repository} /var/www/${vhost}",
     user => www,
     minute  => '5-59/20',
   }
 
 }