Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/bindings/library.js

Issue 29431555: Issue 5216 - [emscripten] Use a more reliable way of retrieving mangled function name (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Created May 6, 2017, 8:36 a.m.
Right Patch Set: Two minor fixes Created May 8, 2017, 11:41 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/bindings/library.h ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 mergeInto(LibraryManager.library, { 20 mergeInto(LibraryManager.library, {
21 GetFunctionName__asm: true, 21 GetFunctionName__asm: true,
22 GetFunctionName__sig: ["iii"], 22 GetFunctionName__sig: [],
Wladimir Palant 2017/05/08 08:53:57 This signature is actually wrong, it should have b
sergei 2017/05/08 09:16:29 Wouldn't it be better to completely remove GetFunc
Wladimir Palant 2017/05/08 10:17:18 This entry is required, GetFunctionName__asm will
23 GetFunctionName: function(buffer, ptr, signature) 23 GetFunctionName: function(buffer, ptr, signature)
24 { 24 {
25 var table = eval("FUNCTION_TABLE_" + AsciiToString(signature)); 25 var table = eval("FUNCTION_TABLE_" + AsciiToString(signature));
26 var name = table[HEAP32[ptr >> 2] % table.length].name; 26 var name = table[HEAP32[ptr >> 2] % table.length].name;
27 Module.stringToAscii(name, buffer); 27 if (buffer)
Wladimir Palant 2017/05/08 08:53:57 This function doesn't need to be called via Module
28 writeAsciiToMemory(name, buffer, true);
29 return name.length;
28 } 30 }
29 }); 31 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld