Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/bindings/library.js

Issue 29431555: Issue 5216 - [emscripten] Use a more reliable way of retrieving mangled function name (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Patch Set: Created May 6, 2017, 8:36 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiled/bindings/library.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiled/bindings/library.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/compiled/bindings/library.js
@@ -0,0 +1,29 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2017 eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+"use strict";
+
+mergeInto(LibraryManager.library, {
+ GetFunctionName__asm: true,
+ GetFunctionName__sig: ["iii"],
Wladimir Palant 2017/05/08 08:53:57 This signature is actually wrong, it should have b
sergei 2017/05/08 09:16:29 Wouldn't it be better to completely remove GetFunc
Wladimir Palant 2017/05/08 10:17:18 This entry is required, GetFunctionName__asm will
+ GetFunctionName: function(buffer, ptr, signature)
+ {
+ var table = eval("FUNCTION_TABLE_" + AsciiToString(signature));
+ var name = table[HEAP32[ptr >> 2] % table.length].name;
+ Module.stringToAscii(name, buffer);
Wladimir Palant 2017/05/08 08:53:57 This function doesn't need to be called via Module
+ }
+});
« no previous file with comments | « compiled/bindings/library.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld