compiled/bindings/generator.h - Issue 29431555: Issue 5216 - [emscripten] Use a more reliable way of retrieving mangled function name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/bindings/generator.h

Issue 29431555: Issue 5216 - [emscripten] Use a more reliable way of retrieving mangled function name (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Slight code improvements Created May 8, 2017, 8:52 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiled/bindings/generator.h

===================================================================

--- a/compiled/bindings/generator.h

+++ b/compiled/bindings/generator.h

@@ -114,17 +114,17 @@ namespace bindings_internal

struct FunctionInfo

{

TypeCategory returnType;

TYPEID pointerType;

std::vector<TypeCategory> args;

bool instance_function;

int effectiveArgs;

TypeCategory effectiveReturnType;

- char name[1024];

+ std::vector<char> name;

sergei 2017/05/08 09:16:29 We are converting it later to std::string, I think

Wladimir Palant 2017/05/08 10:17:18 Done.

FunctionInfo();

FunctionInfo(TypeCategory returnType, TYPEID pointerType,

std::initializer_list<TypeCategory> argTypes, bool instance_function,

void* function);

template<typename ReturnType, typename... Args>

« no previous file with comments | « compile ('k') | compiled/bindings/generator.cpp » ('j') | compiled/bindings/generator.cpp » ('J')