compile - Issue 29431555: Issue 5216 - [emscripten] Use a more reliable way of retrieving mangled function name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compile

Issue 29431555: Issue 5216 - [emscripten] Use a more reliable way of retrieving mangled function name (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Use std::string for function name rather than std::vector Created May 8, 2017, 10:12 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compile

===================================================================

--- a/compile

+++ b/compile

@@ -70,17 +70,18 @@ def getenv(emscripten_config):

'NODE_JS': scope.get('NODE_JS', 'node'),

})

return env

def generate_bindings(env):

params = [

env['PYTHON'], os.path.join(env['EMSCRIPTEN'], 'emcc'),

- '-o', BINDINGS_GENERATOR, '-std=gnu++14', '--js-library', JS_LIBRARY,

+ '-o', BINDINGS_GENERATOR, '-std=c++1z', '--js-library', JS_LIBRARY,

sergei 2017/05/08 10:58:19 does c++1z influence somehow on the generated code

Wladimir Palant 2017/05/08 11:41:34 No, the build is identical. The only thing changin

+ '--js-library', os.path.join(SOURCE_DIR, 'bindings', 'library.js'),

] + list(get_source_files('bindings'))

subprocess.check_call(params, env=env)

with open(BINDINGS_OUTPUT, 'w') as file:

subprocess.check_call([env['NODE_JS'], BINDINGS_GENERATOR],

stdout=file)

« no previous file with comments | « no previous file | compiled/bindings/generator.h » ('j') | compiled/bindings/generator.cpp » ('J')