Issue 29433591: Issue 5180 - start to inject implementation of WebRequest into JsEngine::ctr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29433591: Issue 5180 - start to inject implementation of WebRequest into JsEngine::ctr (Closed)

Created:
May 8, 2017, 11:59 a.m. by sergei

Modified:
May 11, 2017, 9:59 a.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

In order to unify the approach JsEngineCreationParameters is introduced in tests. In the affected places the implementation of timer is also injected, however not always throwing or noop. Add: - ThrowingTimer - NoopTimer - NoopWebRequest

Patch Set 1 #

Created: May 8, 2017, 11:59 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -53 lines)			Patch
M	test/BaseJsTest.h	View	4 chunks	+35 lines, -5 lines	0 comments	Download
M	test/BaseJsTest.cpp	View	1 chunk	+16 lines, -3 lines	0 comments	Download
M	test/FilterEngine.cpp	View	5 chunks	+27 lines, -18 lines	0 comments	Download
M	test/GlobalJsObject.cpp	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	test/Notification.cpp	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	test/Prefs.cpp	View	2 chunks	+10 lines, -9 lines	0 comments	Download
M	test/UpdateCheck.cpp	View	3 chunks	+9 lines, -8 lines	0 comments	Download
M	test/WebRequest.cpp	View	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages