Issue 5180 - start to inject implementation of WebRequest into JsEngine::ctr

test/Prefs.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <sstream>
 
 #include "../src/Thread.h"
 #include "BaseJsTest.h"
 
+using namespace AdblockPlus;
+
 namespace
 {
   typedef std::shared_ptr<AdblockPlus::FilterEngine> FilterEnginePtr;
 
   class TestFileSystem : public LazyFileSystem
   {
   public:
     std::string prefsContents;
 
     std::shared_ptr<std::istream> Read(const std::string& path) const
@@ skipping 25 matching lines @@
         return result;
       }
 
       return LazyFileSystem::Stat(path);
     }
   };
 
   class PrefsTest : public ::testing::Test
   {
   protected:
-    TestFileSystem* fileSystem;
-    AdblockPlus::FileSystemPtr fileSystemPtr;
+    std::shared_ptr<TestFileSystem> fileSystem;
     AdblockPlus::JsEnginePtr jsEngine;
 
     void SetUp()
     {
-      fileSystem = new TestFileSystem();
-      fileSystemPtr.reset(fileSystem);
-
+      fileSystem = std::make_shared<TestFileSystem>();
       ResetJsEngine();
     }
 
     void ResetJsEngine()
     {
-      jsEngine = CreateJsEngine();
-      jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new LazyLogSystem));
-      jsEngine->SetFileSystem(fileSystemPtr);
-      jsEngine->SetWebRequest(std::make_shared<LazyWebRequest>());
+      JsEngineCreationParameters jsEngineParams;
+      jsEngineParams.fileSystem = fileSystem;
+      jsEngineParams.webRequest.reset(new NoopWebRequest());
+      jsEngineParams.logSystem.reset(new LazyLogSystem());
+      jsEngineParams.timer.reset(new NoopTimer());
+      jsEngine = CreateJsEngine(std::move(jsEngineParams));
     }
 
     FilterEnginePtr CreateFilterEngine(const AdblockPlus::FilterEngine::Prefs& preconfiguredPrefs =
       AdblockPlus::FilterEngine::Prefs())
     {
       AdblockPlus::FilterEngine::CreationParameters createParams;
       createParams.preconfiguredPrefs = preconfiguredPrefs;
       return AdblockPlus::FilterEngine::Create(jsEngine, createParams);
     }
   };
@@ skipping 112 matching lines @@
   {
     ResetJsEngine();
     AdblockPlus::FilterEngine::Prefs preconfiguredPrefs;
     preconfiguredPrefs.emplace("suppress_first_run_page", jsEngine->NewValue(true));
     auto filterEngine = CreateFilterEngine(preconfiguredPrefs);
 
     ASSERT_TRUE(filterEngine->GetPref("suppress_first_run_page").IsBool());
     ASSERT_FALSE(filterEngine->GetPref("suppress_first_run_page").AsBool());
   }
 }