Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29433621: Noissue - [emscripten] Make bindings slightly more efficient by resolving classes when mappings are… (Closed)

Created:
May 8, 2017, 1:25 p.m. by Wladimir Palant
Modified:
May 8, 2017, 3:04 p.m.
Reviewers:
sergei
CC:
hub, Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Not a whole lot of impact, around 5% on the current performance test (hard to measure actually). But this gets us closer to the classic code in this test.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M compiled/bindings/generator.h View 1 chunk +0 lines, -7 lines 0 comments Download
M compiled/bindings/generator.cpp View 2 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
May 8, 2017, 1:25 p.m. (2017-05-08 13:25:08 UTC) #1
sergei
May 8, 2017, 1:28 p.m. (2017-05-08 13:28:42 UTC) #2
LGTM, though I have not run it.

Powered by Google App Engine
This is Rietveld