Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(376)

Issue 29433651: Issue 5219 - Update README.md (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by diegocarloslima
Modified:
2 years, 5 months ago
Reviewers:
Felix Dahlke, anton
CC:
René Jeschke, jens
Visibility:
Public.

Description

Issue 5219 - Update README.md

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adjusting Java requirements #

Total comments: 6

Patch Set 3 : Ajustments related to Felix's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M README.md View 1 2 1 chunk +34 lines, -12 lines 0 comments Download

Messages

Total messages: 7
diegocarloslima
https://codereview.adblockplus.org/29433651/diff/29433652/README.md File README.md (left): https://codereview.adblockplus.org/29433651/diff/29433652/README.md#oldcode20 README.md:20: Importing into Eclipse Should we remove the Eclipse section? ...
2 years, 8 months ago (2017-05-08 21:04:02 UTC) #1
anton
https://codereview.adblockplus.org/29433651/diff/29433652/README.md File README.md (right): https://codereview.adblockplus.org/29433651/diff/29433652/README.md#newcode15 README.md:15: - Java 7 It may be not clear a ...
2 years, 8 months ago (2017-05-10 06:16:52 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29433651/diff/29433652/README.md File README.md (right): https://codereview.adblockplus.org/29433651/diff/29433652/README.md#newcode15 README.md:15: - Java 7 On 2017/05/10 06:16:52, anton wrote: > ...
2 years, 8 months ago (2017-05-10 14:27:22 UTC) #3
anton
On 2017/05/10 14:27:22, diegocarloslima wrote: > https://codereview.adblockplus.org/29433651/diff/29433652/README.md > File README.md (right): > > https://codereview.adblockplus.org/29433651/diff/29433652/README.md#newcode15 > ...
2 years, 8 months ago (2017-05-22 13:06:30 UTC) #4
Felix Dahlke
https://codereview.adblockplus.org/29433651/diff/29435639/README.md File README.md (right): https://codereview.adblockplus.org/29433651/diff/29435639/README.md#newcode36 README.md:36: We're compiling against Android API 25, so make sure ...
2 years, 7 months ago (2017-05-23 11:16:27 UTC) #5
diegocarloslima
https://codereview.adblockplus.org/29433651/diff/29435639/README.md File README.md (right): https://codereview.adblockplus.org/29433651/diff/29435639/README.md#newcode36 README.md:36: We're compiling against Android API 25, so make sure ...
2 years, 7 months ago (2017-05-23 12:07:12 UTC) #6
Felix Dahlke
2 years, 6 months ago (2017-07-20 16:43:16 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5