Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29434565: Issue 5208 - Adding new hires and fix typos on eyeo.com/team/ (Closed)

Created:
May 9, 2017, 12:11 p.m. by ire
Modified:
May 16, 2017, 6:42 p.m.
Reviewers:
Lisa, juliandoucette
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Description

Issue 5208 - Adding new hires and fix typos on eyeo.com/team/

Patch Set 1 #

Total comments: 36

Patch Set 2 : Content Fixes & Include new person (Linus Olsson) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M includes/globals.tmpl View 1 1 chunk +36 lines, -32 lines 0 comments Download
A static/images/flags/ng.png View Binary file 0 comments Download
A static/images/flags/se.png View 1 Binary file 0 comments Download
A static/images/people/ire.png View Binary file 0 comments Download
A static/images/people/jan.png View Binary file 0 comments Download
A static/images/people/jens.png View Binary file 0 comments Download
A static/images/people/linus.png View 1 Binary file 0 comments Download

Messages

Total messages: 11
ire
May 9, 2017, 12:11 p.m. (2017-05-09 12:11:11 UTC) #1
juliandoucette
The plural error below suggests to me that this content has not been reviewed by ...
May 9, 2017, 12:25 p.m. (2017-05-09 12:25:16 UTC) #2
ire
Okay. I'll await content review from Lisa. Regarding the separation, there are a few other ...
May 9, 2017, 12:42 p.m. (2017-05-09 12:42:56 UTC) #3
Lisa
Thanks, Julian! I've been meaning to get around to fixing the errors on this page ...
May 9, 2017, 1:23 p.m. (2017-05-09 13:23:53 UTC) #4
Lisa
https://codereview.adblockplus.org/29434565/diff/29434566/includes/globals.tmpl File includes/globals.tmpl (right): https://codereview.adblockplus.org/29434565/diff/29434566/includes/globals.tmpl#newcode12 includes/globals.tmpl:12: ("2013-06-18", "us", "ben.jpeg", "Ben Williams", "Comms/Ops Manager", "Previously worked ...
May 9, 2017, 2:29 p.m. (2017-05-09 14:29:31 UTC) #5
ire
Thanks Lisa, I will make those updates.
May 9, 2017, 3:24 p.m. (2017-05-09 15:24:12 UTC) #6
juliandoucette
On 2017/05/09 15:24:12, ire wrote: > Thanks Lisa, I will make those updates. That's a ...
May 16, 2017, 1:42 p.m. (2017-05-16 13:42:53 UTC) #7
juliandoucette
On 2017/05/16 13:42:53, juliandoucette wrote: > On 2017/05/09 15:24:12, ire wrote: > > Thanks Lisa, ...
May 16, 2017, 1:44 p.m. (2017-05-16 13:44:11 UTC) #8
ire
On 2017/05/16 13:44:11, juliandoucette wrote: > Can you make sure that these changes are also ...
May 16, 2017, 2:05 p.m. (2017-05-16 14:05:44 UTC) #9
Lisa
On 2017/05/16 14:05:44, ire wrote: > On 2017/05/16 13:44:11, juliandoucette wrote: > > > Can ...
May 16, 2017, 2:10 p.m. (2017-05-16 14:10:48 UTC) #10
juliandoucette
May 16, 2017, 3:34 p.m. (2017-05-16 15:34:41 UTC) #11
LGTM

Powered by Google App Engine
This is Rietveld