Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29435645: Issue 4688 - stop using of LazyWebRequest in tests/UpdateCheck.cpp (Closed)

Created:
May 10, 2017, 4:38 p.m. by sergei
Modified:
May 11, 2017, 9:59 a.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# based on https://codereview.adblockplus.org/29433591/

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -51 lines) Patch
M test/BaseJsTest.h View 3 chunks +72 lines, -0 lines 0 comments Download
M test/BaseJsTest.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M test/UpdateCheck.cpp View 14 chunks +51 lines, -51 lines 3 comments Download

Messages

Total messages: 5
sergei
May 10, 2017, 4:41 p.m. (2017-05-10 16:41:58 UTC) #1
hub
LGTM short of the cosmetic comment. https://codereview.adblockplus.org/29435645/diff/29435646/test/UpdateCheck.cpp File test/UpdateCheck.cpp (right): https://codereview.adblockplus.org/29435645/diff/29435646/test/UpdateCheck.cpp#newcode79 test/UpdateCheck.cpp:79: { Maybe I'm ...
May 10, 2017, 5:53 p.m. (2017-05-10 17:53:19 UTC) #2
sergei
https://codereview.adblockplus.org/29435645/diff/29435646/test/UpdateCheck.cpp File test/UpdateCheck.cpp (right): https://codereview.adblockplus.org/29435645/diff/29435646/test/UpdateCheck.cpp#newcode79 test/UpdateCheck.cpp:79: { On 2017/05/10 17:53:19, hub wrote: > Maybe I'm ...
May 10, 2017, 6:15 p.m. (2017-05-10 18:15:54 UTC) #3
hub
https://codereview.adblockplus.org/29435645/diff/29435646/test/UpdateCheck.cpp File test/UpdateCheck.cpp (right): https://codereview.adblockplus.org/29435645/diff/29435646/test/UpdateCheck.cpp#newcode79 test/UpdateCheck.cpp:79: { On 2017/05/10 18:15:54, sergei wrote: > On 2017/05/10 ...
May 10, 2017, 6:55 p.m. (2017-05-10 18:55:54 UTC) #4
hub
May 10, 2017, 6:56 p.m. (2017-05-10 18:56:57 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld