Noissue - Generate content on provision

modules/web/manifests/server.pp

 class web::server(
     $vhost,
     $repository,
     $certificate = hiera('web::server::certificate', 'undef'),
     $private_key = hiera('web::server::private_key', 'undef'),
     $is_default = false,
     $aliases = undef,
     $custom_config = undef,
     $multiplexer_locations = undef,
     $geoip = false,
@@ skipping 96 matching lines @@
 
   exec {"fetch_repo":
     command => "hg clone -U https://hg.adblockplus.org/${repository} /home/www/${repository}",
     path => ["/usr/bin/", "/bin/"],
     require => Package['mercurial'],
     user => www,
     timeout => 0,
     creates => "/home/www/${repository}/.hg/hgrc",
   }
 
+  exec {"generate_static_pages":
+    command => "python -m cms.bin.generate_static_pages /home/www/${repository} /var/www/${vhost}",

[mathias, 2017/05/10 17:56:00]

Please export the bits shared with the cronjob command to variables, and use
shellquote() to combine them into the respective resource's command parameter.

+    path => ["/usr/bin/", "/bin/"],
+    user => www,
+    require => [Exec["fetch_repo"], Exec["fetch_cms"]],
+    environment => 'PYTHONPATH=/opt/cms:/opt/sitescripts',
+  }
+
   file {'/var/www':
     ensure => directory,
     mode => 755,
   }
 
   file {[
     "/var/cache/$repository",
     "/var/www/$vhost",
     "/var/www/docs",
   ]:
     ensure => directory,
     owner => www,
     mode => 755,
   }
 
   cron {'update_cms':
     ensure => present,
     command => "hg pull -q -u -R /opt/cms",
     minute  => '4-59/20',
   }
 
   cron {'update_repo':
     ensure => present,
     command => "hg pull -q -R /home/www/${repository} && python -m cms.bin.generate_static_pages /home/www/${repository} /var/www/${vhost}",
     user => www,
     minute  => '5-59/20',
   }
 
 }