Noissue - Generate content on provision

modules/web/manifests/server.pp

 class web::server(
     $vhost,
     $repository,
     $certificate = hiera('web::server::certificate', 'undef'),
     $private_key = hiera('web::server::private_key', 'undef'),
     $is_default = false,
     $aliases = undef,
     $custom_config = undef,
     $multiplexer_locations = undef,
     $geoip = false,
 ) {
 
   include sitescripts
 
+  $PYTHONPATH = 'PYTHONPATH=/opt/cms:/opt/sitescripts'
+
   # Ensure there is at least one character in the respective strings;
   # see https://codereview.adblockplus.org/29329028/#msg3
   validate_re($vhost, '.+')
   validate_re($repository, '.+')
 
   File {
     owner  => 'root',
     group  => 'root',
     mode   => 0644,
   }
 
   Cron {
     environment => concat(hiera('cron::environment', []), [
-      'PYTHONPATH=/opt/cms:/opt/sitescripts',
+      $PYTHONPATH,
     ]),
   }
 
   class {'nginx':
     geoip_country => $geoip ? {
       false => undef,
       default => '/usr/share/GeoIP/GeoIPv6.dat',
     },
   }
 
@@ skipping 68 matching lines @@
 
   exec {"fetch_repo":
     command => "hg clone -U https://hg.adblockplus.org/${repository} /home/www/${repository}",
     path => ["/usr/bin/", "/bin/"],
     require => Package['mercurial'],
     user => www,
     timeout => 0,
     creates => "/home/www/${repository}/.hg/hgrc",
   }
 
+  $initialize_content_exec = [
+    'python', '-m', 'cms.bin.generate_static_pages',
+    "/home/www/${repository}", "/var/www/${vhost}",
+  ]
+
+  if $::environment == 'development' {

[mathias, 2017/05/12 16:42:12]

If you'd used refreshonly => $::environment != "development" on the exec
resource you would not only minimize complexity and have a resource definition
available irregardless of whether it runs (which eases ordering when necessary),
but also ensure a newly provisioned server in production would be able to serve
content right after provisioning.

[f.lopez, 2017/05/12 17:43:39]

You are right.

+    exec {"initialize_content":
+      command => shellquote($initialize_content_exec),
+      path => ["/usr/bin/", "/bin/"],
+      user => www,
+      require => [Exec["fetch_repo"], Exec["fetch_cms"]],
+      environment => $PYTHONPATH,
+    }
+  }
+
   file {'/var/www':
     ensure => directory,
     mode => 755,
   }
 
   file {[
     "/var/cache/$repository",
     "/var/www/$vhost",
     "/var/www/docs",
   ]:
     ensure => directory,
     owner => www,
     mode => 755,
   }
 
   cron {'update_cms':
     ensure => present,
     command => "hg pull -q -u -R /opt/cms",
     minute  => '4-59/20',
   }
 
   cron {'update_repo':
     ensure => present,
-    command => "hg pull -q -R /home/www/${repository} && python -m cms.bin.generate_static_pages /home/www/${repository} /var/www/${vhost}",
+    command => "hg pull -q -R /home/www/${repository} && ${initialize_content_exec} /home/www/${repository} /var/www/${vhost}",

[mathias, 2017/05/12 16:42:12]

Please export the commands preceeding and following $initialize_content_exec in
the same fashion as the latter, and join([$preceding, $i_c_e, $following], "
&&\n") afterwards, or similar (i.e. join(['set -e', $p, $i_c_e, $f], ';')).

[f.lopez, 2017/05/12 17:43:39]

I actually thought of this but for a different commit, should I do it in this
one then? cause I'd like to do it for all the exec resources in this manifest
since I'm already here

     user => www,
     minute  => '5-59/20',
   }
 
 }