#301 - Provision formmail templates with absolute paths

hiera/roles/web/acceptableads.yaml

Index: hiera/roles/web/acceptableads.yaml
===================================================================
--- a/hiera/roles/web/acceptableads.yaml
+++ b/hiera/roles/web/acceptableads.yaml
@@ -1,3 +1,24 @@
+committee_application_template: &committee_application_template |
+  To: committee@acceptableads.org
+  From: donotreply@adblockplus.org
+  Reply-To: {{(fields.name,fields.email)|emailaddr|mime}}
+  Subject: Submission for Acceptable Ads committee by {{fields.name|mime}} from {{fields.company|mime}}
+  Content-Transfer-Encoding: 8bit
+  Content-Type: text/plain; charset="UTF-8"
+
+  {{fields.name}} would like to apply for the Acceptable Ads committee:
+
+  Name: {{fields.name}}
+  Title: {{fields.title}}
+  Company: {{fields.company}}
+  Email: {{fields.email}}
+  Phone: {{fields.phone}}
+  Group: {{fields.group}}
+
+  Motivation:
+  {{fields.motivation}}
+
+
 classes:
   statsclient:
   web::server:
@@ -12,6 +33,10 @@
     multiplexer_locations:
       - /committee/apply/submit
     repository: web.acceptableads.com
+    formmail:
+      path: "/var/committee.mail"

[f.nicolaisen, 2017/05/16 08:41:54]

See my next comment about dir.

[f.lopez, 2017/05/16 19:43:24]

Acknowledged.

+      ensure: present
+      content: *committee_application_template
 
 sitescripts::configfragments:
   committee_form:
@@ -23,7 +48,7 @@
       sitescripts.formmail.web.formmail2 =
       [formmail2]
       committee.url = /committee/apply/submit
-      committee.template = formmail/template/committee.mail
+      committee.template = /var/committee.mail

[f.nicolaisen, 2017/05/16 08:41:54]

I would not understand what this file is for when browsing the filesystem. I
would find it clearer if there's a directory for sitescripts/formmail
configuration with the committee.mail file inside.

[f.lopez, 2017/05/16 19:43:24]

To be fair, a managed system is not supposed to be browsed manually.
I can agree with this at some extent, I did this because with puppet is kinda
hard to create a full path in case it doesn't exist, and since the configuration
is in hiera, you don't have to understand the parts from the filesystem but from
hiera itself.

       committee.fields.name = mandatory
       committee.fields.title = mandatory
       committee.fields.title.mandatory = No job title entered