Delta Between Two Patch Sets: modules/web/manifests/server.pp
Issue 29438568:
Noissue - Improve CMS repository pull command (Closed)
Left Patch Set:
Created May 16, 2017, 12:58 a.m.
Right Patch Set: For comment 3 as well
Created May 16, 2017, 7:11 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 class web::server( | 1 class web::server( |
| 2 $vhost, | 2 $vhost, |
| 3 $repository, | 3 $repository, |
| 4 $certificate = hiera('web::server::certificate', 'undef'), | 4 $certificate = hiera('web::server::certificate', 'undef'), |
| 5 $private_key = hiera('web::server::private_key', 'undef'), | 5 $private_key = hiera('web::server::private_key', 'undef'), |
| 6 $is_default = false, | 6 $is_default = false, |
| 7 $aliases = undef, | 7 $aliases = undef, |
| 8 $custom_config = undef, | 8 $custom_config = undef, |
| 9 $multiplexer_locations = undef, | 9 $multiplexer_locations = undef, |
| 10 $geoip = false, | 10 $geoip = false, |
| (...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 139 "/var/cache/$repository", | 139 "/var/cache/$repository", |
| 140 "/var/www/$vhost", | 140 "/var/www/$vhost", |
| 141 "/var/www/docs", | 141 "/var/www/docs", |
| 142 ]: | 142 ]: |
| 143 ensure => directory, | 143 ensure => directory, |
| 144 owner => www, | 144 owner => www, |
| 145 mode => 755, | 145 mode => 755, |
| 146 } | 146 } |
| 147 | 147 |
| 148 $update_cms_cmd = [ | 148 $update_cms_cmd = [ |
| 149 "hg", "pull", "-q", "-u", "-R", "/opt/cms", | 149 'hg', 'pull', |
|
mathias
2017/05/16 09:00:07
This should be all single quotes.
| |
| 150 '--quiet', | |
| 151 '--update', | |
| 152 '--repository', '/opt/cms', | |
| 150 ] | 153 ] |
| 151 | 154 |
| 152 cron {'update_cms': | 155 cron {'update_cms': |
| 153 ensure => present, | 156 ensure => present, |
| 154 command => shellquote($update_cms_cmd), | 157 command => shellquote($update_cms_cmd), |
| 155 minute => '4-59/20', | 158 minute => '4-59/20', |
| 156 } | 159 } |
| 157 | 160 |
| 158 $update_repo_cmd = [ | 161 $update_repo_cmd = [ |
| 159 "hg", "pull", "-q", "-R", "/home/www/${repository}", | 162 "hg", "pull", "-q", "-R", "/home/www/${repository}", |
| 160 ] | 163 ] |
| 161 | 164 |
| 162 $update_webpage_cmd = join( | 165 $update_webpage_cmd = join( |
| 163 [ | 166 [ |
| 164 shellquote($update_repo_cmd), | 167 shellquote($update_repo_cmd), |
| 165 shellquote($initialize_content_exec) | 168 shellquote($initialize_content_exec) |
| 166 ], | 169 ], |
| 167 "&&" | 170 "&&" |
| 168 ) | 171 ) |
| 169 | 172 |
| 170 cron {'update_repo': | 173 cron {'update_repo': |
| 171 ensure => present, | 174 ensure => present, |
| 172 command => $update_webpage_cmd, | 175 command => $update_webpage_cmd, |
| 173 user => www, | 176 user => www, |
| 174 minute => '5-59/20', | 177 minute => '5-59/20', |
| 175 } | 178 } |
| 176 | 179 |
| 177 } | 180 } |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
