Issue 5135 - Reduce font size and padding on smaller screens on acceptableads.com

static/scss/components/_groups.scss

 // This file is part of acceptableads.org.
 // Copyright (C) 2016 Eyeo GmbH
 //
 // acceptableads.org is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // acceptableads.org is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with acceptableads.org.  If not, see <http://www.gnu.org/licenses/>.
 
 // display like a table (even grid)
 
 .group-container
 {
   width: 100%;
   max-width: $max-width;
   margin: 0 auto;
   padding: $xl 0;
 
-  @media screen and (max-width: $desktop-breakpoint)

[juliandoucette, 2017/05/30 14:22:57]

Note: There was an inconsistent border-left on card group items that was made
more apparent to me when reviewing this change. I pushed an non-issue fix for
this https://hg.adblockplus.org/web.acceptableads.com/rev/86d35c4f2fb5.

[ire, 2017/05/30 17:44:59]

Okay. Do I need to apply those changes here, or will the difference be resolved
when this issue is pushed?

[juliandoucette, 2017/06/07 18:05:28]

You can just pull and rebase if there is a conflict (I don't think there will
be).

+  @media (max-width: $desktop-breakpoint)
   {
     padding: $xs;
   }
 }
 
 .group-container > %headings,
 .group-container > p
 {
-  margin: $xl auto;
+  margin: $lg auto;
   padding: 0 $sm;
 }
 
 
 .group-container > p

[juliandoucette, 2017/05/30 14:22:57]

Looks good on mobile, but not on desktop. I think we should shrink this space on
desktop too. 

[ire, 2017/05/30 17:44:58]

Acknowledged.

 {
-  @media screen and (max-width: $desktop-breakpoint)
+  @media (max-width: $desktop-breakpoint)
   {
     margin: $md auto;
   }
 }
 
 
 
 .group
 {
   display: table;
   width: 100%;
   table-layout: fixed;
 }
 
 .group-container .group
 {
   margin-bottom: 0;
 }
 
 .group-container > %headings
 {
   margin-top: 0;
 
-  @media screen and (max-width: $desktop-breakpoint)
+  @media (max-width: $desktop-breakpoint)
   {
     margin: $md auto;
   }
 }
 
 .group .card,
 .group .item
 {
   display: table-cell;
   vertical-align: top;
 }
 
 .group.items .item::before
 {
   margin-top: $sm;
   @extend h3;
   text-align: center;
   width: 45px;
 }
 
 // fix 1px border ltr and rtrl on desktop
 
 html[dir="ltr"] .group .card + .card
 {
   border-left: 0;
 }
 
+@media(max-width: $tablet-breakpoint)
+{
+  html[dir="ltr"] .group .card:first-child
+  {
+    border-left: 0;
+  }
+}
+
 html[dir="rtl"] .group .card + .card
 {
   border-right: 0;
+}
+
+@media(max-width: $tablet-breakpoint)
+{
+  html[dir="rtl"] .group .card:last-child
+  {
+    border-right: 0;
+  }
 }
 
 // start a little lower than cards to add extra spacing on top and sides
 .group.items .item
 {
   position: relative;
   margin-bottom: $md;
   padding: 0 $sm;
 }
 
@@ skipping 172 matching lines @@
     width: 100%;
   }
   // un-center all cards
   .group > div:nth-child(4),
   .group > div:nth-child(3),
   .group > div:nth-child(5)
   {
     margin-left: 0;
   }
 }