Issue 5135 - Reduce font size and padding on smaller screens on acceptableads.com

static/scss/components/_groups.scss

 // This file is part of acceptableads.org.
 // Copyright (C) 2016 Eyeo GmbH
 //
 // acceptableads.org is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // acceptableads.org is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 41 matching lines @@
   display: table;
   width: 100%;
   table-layout: fixed;
 }
 
 .group-container .group
 {
   margin-bottom: 0;
 }
 
 .group-container > %headings

[juliandoucette, 2017/06/09 14:08:26]

NIT: I don't like `margin-top: 0` here. It seems like we should drop the
vertical padding on `.group-container` and rely on the margin applied to it's
children for vertical spacing. What do you think?

[ire, 2017/06/14 15:41:13]

I'm not sure about this. The way I see it, all `.group-container`s should have
the same amount of padding. Relying on the children will make the padding
inconsistent, and also depends on the children having a top margin to begin
with. 

Note: For most things like headings, I prefer to apply margins in one direction
only (usually bottom). This way there is less conflict. I prefer margin-bottom
as I've found that margin-top is more likely to interfere with other things on
the page.

In this case, I think the overriding of the top margin is fine. Given the way
margins are applied, I think we are bound to have cases were overriding is
necessary. 

 

 {
   margin-top: 0;
 
   @media (max-width: $desktop-breakpoint)
   {
     margin: $md auto;
   }
 }
 
 .group .card,
@@ skipping 11 matching lines @@
   width: 45px;
 }
 
 // fix 1px border ltr and rtrl on desktop
 
 html[dir="ltr"] .group .card + .card
 {
   border-left: 0;
 }
 
+@media(max-width: $tablet-breakpoint)
+{
+  html[dir="ltr"] .group .card:first-child
+  {
+    border-left: 0;
+  }
+}
+
 html[dir="rtl"] .group .card + .card
 {
   border-right: 0;
+}
+
+@media(max-width: $tablet-breakpoint)
+{
+  html[dir="rtl"] .group .card:last-child
+  {
+    border-right: 0;
+  }
 }
 
 // start a little lower than cards to add extra spacing on top and sides
 .group.items .item
 {
   position: relative;
   margin-bottom: $md;
   padding: 0 $sm;
 }
 
@@ skipping 172 matching lines @@
     width: 100%;
   }
   // un-center all cards
   .group > div:nth-child(4),
   .group > div:nth-child(3),
   .group > div:nth-child(5)
   {
     margin-left: 0;
   }
 }