Issue 5135 - Reduce font size and padding on smaller screens on acceptableads.com

static/scss/content/_typography.scss

 // This file is part of acceptableads.org.
 // Copyright (C) 2016 Eyeo GmbH
 //
 // acceptableads.org is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // acceptableads.org is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 139 matching lines @@
 blockquote,
 p,
 ul,
 ol,
 dl,
 .block
 {
   margin: $sm 0;
 }
 
-.p-container

[ire, 2017/06/27 08:36:31]

Note: I couldn't really figure out where else to put this class. If you have any
better suggestions, let me know. 

[juliandoucette, 2017/07/03 23:12:38]

I don't like the name of this class because it's too specific (it contains more
than *just* paragraphs).

I'm also confused about it's usage. It seems to do the same thing as .section
except only margin-bottom. But, at least in the case of h1, hr, [p]N, why not
just wrap the group in a .section (the header margin should collapse)?

That this class is necessary so often suggest to me that something is wrong with
our structure or defaults.

[ire, 2017/07/04 11:03:11]

Yeah you'e right it could have a better name. 

I tried to use the .section but it wasn't quite right. What I was going for with
this class was more a container for:

1. The main pargraphs on the page. e.g. in pages/committee/apply.md, the class
is applied only around that part of the page
2. The main section of the page. e.g. in pages/solutions/publishers.md, the
class is applied around basically the whole content area of the page. 

In these cases the .section class didn't really work. But perhaps there is
another class, similar to .section we can extend? Or rename this .p-container
class with something that is more general like .section is?

[juliandoucette, 2017/07/04 15:33:08]

This is what I had in mind.

But it's not clear:
- Why .section didn't work
- Whether or not .section could/should work (if modified)

I don't have a strong opinion on using .section or not. Rather, I just want
*whatever-it-is* to be straightforward. So that when I create another page I
know whether or not to use this class and why.

If you see https://acceptableads.com/en/styleguide (a hidden and depricated
page) you can get the idea about what .section was meant for at the bottom.
There were 3 different colour sections [primary, secondary, accent] and they all
had xl margin and padding and their margins would collapse if they appeared
after each other.

The class that you seem to be proposing seems something like a .content-section
or .content-container - a container (that provides spacing) meant for content
within .section-s and/or columns. But it's not entirely clear me to yet (what it
is or should be or why).

I hope that this comment is clear and I'm not repeating myself :D - thank you
for your patience.

[ire, 2017/07/05 10:33:09]

Ah I see what you mean! The .section class *should* work in this case, and I
think with some refactoring it could. In fact, the margin-top on the .section
class is almost almost collapsed, so we may be able to refactor it to only
applying a margin on the bottom without having to change too much. I'll make the
change in the next patch. 

[ire, 2017/07/05 10:53:50]

Done.

-{
-  margin-bottom: $md;
-
-  @media (min-width: $mobile-breakpoint)
-  {
-    margin-bottom: $lg;
-  }
-
-  @media (min-width: $tablet-breakpoint)
-  {
-    margin-bottom: $xl;
-  }
-}
-
-.p-container p:first-child 

[ire, 2017/06/27 08:36:32]

This is a change from the `.row p:first-child` selector. Let me know if a
comment is still needed.

-{
-  margin-top: 0;
-}
-
 // Links ///////////////////////////////////////////////////////////////////////
 
 a
 {
   cursor: pointer;
   text-decoration: underline;
   color: $accent;
   font-weight: 400;
 }
 
@@ skipping 255 matching lines @@
   // hr background color is the line color
   background-color: $primary-fg;
 }
 
 // Place hr under h1 or h2 inside hN margin
 h1 + hr,
 h2 + hr
 {
   position: absolute;
   margin: -$md 0 $md 0;
+
+  @media (max-width: $mobile-breakpoint) 
+  {
+    margin-top: -$sm - 5px;

[ire, 2017/07/06 10:31:38]

The $xs size was every so slightly off

+  }
 }
 
 // center hr in centered blocks
 .center hr
 {
   margin: $sm auto;
 }
 
 // Tables //////////////////////////////////////////////////////////////////////
 
@@ skipping 33 matching lines @@
 {
   vertical-align: bottom;
   text-transform: uppercase;
   border-bottom: 2px solid $info;
 }
 
 table tbody + tbody
 {
   border-top: 2px solid $info;
 }