Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(500)

Issue 29441558: Issue 5243 - Clipped text across languages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by jens
Modified:
2 weeks, 6 days ago
Reviewers:
diegocarloslima
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 5243 - Clipped text across languages

Patch Set 1 #

Total comments: 12

Patch Set 2 : Added copyright header, extracted static method to set multiline property in onBindView(), added multi line property for subscriptions screen #

Total comments: 4

Patch Set 3 : Fixed layout name and bracket in preferences_main.xml #

Messages

Total messages: 7
jens
1 month ago (2017-05-18 12:59:33 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29441558/diff/29441559/adblockplussbrowser/res/xml/preferences_main.xml File adblockplussbrowser/res/xml/preferences_main.xml (left): https://codereview.adblockplus.org/29441558/diff/29441559/adblockplussbrowser/res/xml/preferences_main.xml#oldcode30 adblockplussbrowser/res/xml/preferences_main.xml:30: Seems that the title is clipping for the PreferenceScreen ...
4 weeks ago (2017-05-25 18:53:56 UTC) #2
jens
https://codereview.adblockplus.org/29441558/diff/29441559/adblockplussbrowser/res/xml/preferences_main.xml File adblockplussbrowser/res/xml/preferences_main.xml (left): https://codereview.adblockplus.org/29441558/diff/29441559/adblockplussbrowser/res/xml/preferences_main.xml#oldcode30 adblockplussbrowser/res/xml/preferences_main.xml:30: On 2017/05/25 18:53:56, diegocarloslima wrote: > Seems that the ...
3 weeks, 2 days ago (2017-05-30 12:17:01 UTC) #3
jens
Added copyright header, extracted static method to set multiline property in onBindView(), added multi line ...
3 weeks, 2 days ago (2017-05-30 12:30:57 UTC) #4
diegocarloslima
https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser/res/layout/multiline_preference_screen.xml File adblockplussbrowser/res/layout/multiline_preference_screen.xml (right): https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser/res/layout/multiline_preference_screen.xml#newcode1 adblockplussbrowser/res/layout/multiline_preference_screen.xml:1: <?xml version="1.0" encoding="utf-8"?> Since this is a general purpose ...
3 weeks, 1 day ago (2017-05-31 13:33:58 UTC) #5
jens
https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser/res/layout/multiline_preference_screen.xml File adblockplussbrowser/res/layout/multiline_preference_screen.xml (right): https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser/res/layout/multiline_preference_screen.xml#newcode1 adblockplussbrowser/res/layout/multiline_preference_screen.xml:1: <?xml version="1.0" encoding="utf-8"?> On 2017/05/31 13:33:58, diegocarloslima wrote: > ...
3 weeks, 1 day ago (2017-05-31 13:58:57 UTC) #6
diegocarloslima
3 weeks ago (2017-06-01 14:41:39 UTC) #7
On 2017/05/31 13:58:57, jens wrote:
>
https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser...
> File adblockplussbrowser/res/layout/multiline_preference_screen.xml (right):
> 
>
https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser...
> adblockplussbrowser/res/layout/multiline_preference_screen.xml:1: <?xml
> version="1.0" encoding="utf-8"?>
> On 2017/05/31 13:33:58, diegocarloslima wrote:
> > Since this is a general purpose preference layout with multiline title
> enabled,
> > I would suggest renaming it to 'multiline_preference.xml'
> 
> Acknowledged.
> 
>
https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser...
> File adblockplussbrowser/res/xml/preferences_main.xml (right):
> 
>
https://codereview.adblockplus.org/29441558/diff/29451662/adblockplussbrowser...
> adblockplussbrowser/res/xml/preferences_main.xml:10: >
> On 2017/05/31 13:33:58, diegocarloslima wrote:
> > the android:title line shouldn't have changed. the closing angle bracket >
> > should stay in the same line
> 
> Acknowledged.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5