adblockplussbrowser/res/xml/preferences_main.xml - Issue 29441558: Issue 5243 - Clipped text across languages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: adblockplussbrowser/res/xml/preferences_main.xml

Issue 29441558: Issue 5243 - Clipped text across languages (Closed)

Patch Set: Added copyright header, extracted static method to set multiline property in onBindView(), added multi line property for subscriptions screen Created May 30, 2017, 12:25 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« adblockplussbrowser/res/layout/multiline_preference_screen.xml ('K') | « adblockplussbrowser/res/layout/multiline_preference_screen.xml ('k') | adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: adblockplussbrowser/res/xml/preferences_main.xml

===================================================================

--- a/adblockplussbrowser/res/xml/preferences_main.xml

+++ b/adblockplussbrowser/res/xml/preferences_main.xml

@@ -4,8 +4,10 @@

android:layout_height="fill_parent" >

<PreferenceScreen

+ android:layout="@layout/multiline_preference_screen"

android:summary="@string/manage_subscriptions_summary"

- android:title="@string/manage_subscriptions" >

+ android:title="@string/manage_subscriptions"

+ >

diegocarloslima 2017/05/31 13:33:58 the android:title line shouldn't have changed. the

jens 2017/05/31 13:58:57 Acknowledged.

<org.adblockplus.sbrowser.contentblocker.ListedSubscriptionsPreferenceCategory

android:layout_width="fill_parent"

@@ -35,7 +37,7 @@

<org.adblockplus.sbrowser.contentblocker.WhitelistedWebsitesPreferenceCategory/>

</PreferenceScreen>

- <ListPreference

+ <org.adblockplus.sbrowser.contentblocker.preferences.MultilineListPreference

android:layout_width="fill_parent"

android:layout_height="wrap_content"

android:defaultValue="1"

@@ -49,7 +51,7 @@

android:layout_height="wrap_content"

android:title="@string/acceptable_ads_category" >

- <CheckBoxPreference

+ <org.adblockplus.sbrowser.contentblocker.preferences.MultilineCheckBoxPreference

android:layout_width="fill_parent"

android:layout_height="wrap_content"

android:defaultValue="true"