Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(813)

Issue 29441585: No Issue - SCSS Media Query Style Proposal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by ire
Modified:
4 weeks ago
Visibility:
Public.

Description

SCSS Media Query Style Proposal

Patch Set 1 #

Total comments: 18
Unified diffs Side-by-side diffs Delta from patch set Stats (+2085 lines, -0 lines) Patch
A .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
A README.md View 1 chunk +39 lines, -0 lines 16 comments Download
A gulpfile.js View 1 chunk +26 lines, -0 lines 1 comment Download
A package.json View 1 chunk +9 lines, -0 lines 0 comments Download
A yarn.lock View 1 chunk +2010 lines, -0 lines 1 comment Download

Messages

Total messages: 17
ire
3 months ago (2017-05-18 22:55:31 UTC) #1
juliandoucette
Thanks Ire :) I will investigate this a little bit more before I give my ...
3 months ago (2017-05-22 11:18:59 UTC) #2
juliandoucette
(Please see the previous message. I meant to send it with these comments on this ...
3 months ago (2017-05-22 11:20:09 UTC) #3
ire
https://codereview.adblockplus.org/29441585/diff/29441586/README.md File README.md (right): https://codereview.adblockplus.org/29441585/diff/29441586/README.md#newcode13 README.md:13: @media (max-width: $tablet-breakpoint) On 2017/05/22 11:20:09, juliandoucette wrote: > ...
3 months ago (2017-05-23 00:03:49 UTC) #4
Thomas Greiner
I like this approach and agree with the reasoning behind it. The only thing I'm ...
3 months ago (2017-05-23 12:17:49 UTC) #5
saroyanm
I also like the reasoning. Bit unsure about the duplication. https://codereview.adblockplus.org/29441585/diff/29441586/README.md File README.md (right): https://codereview.adblockplus.org/29441585/diff/29441586/README.md#newcode37 ...
3 months ago (2017-05-23 14:55:24 UTC) #6
ire
https://codereview.adblockplus.org/29441585/diff/29441586/README.md File README.md (right): https://codereview.adblockplus.org/29441585/diff/29441586/README.md#newcode37 README.md:37: - The major issue with this method is that, ...
3 months ago (2017-05-23 17:20:11 UTC) #7
Thomas Greiner
https://codereview.adblockplus.org/29441585/diff/29441586/README.md File README.md (right): https://codereview.adblockplus.org/29441585/diff/29441586/README.md#newcode37 README.md:37: - The major issue with this method is that, ...
3 months ago (2017-05-23 18:30:35 UTC) #8
juliandoucette
Thanks Thomas & Manvel. Am I correct in concluding that we have agreement already excluding ...
3 months ago (2017-05-24 11:44:18 UTC) #9
ire
https://codereview.adblockplus.org/29441585/diff/29441586/README.md File README.md (right): https://codereview.adblockplus.org/29441585/diff/29441586/README.md#newcode37 README.md:37: - The major issue with this method is that, ...
3 months ago (2017-05-24 13:06:27 UTC) #10
Thomas Greiner
On 2017/05/24 11:44:18, juliandoucette wrote: > Am I correct in concluding that we have agreement ...
3 months ago (2017-05-24 17:19:59 UTC) #11
juliandoucette
LGTM Please open a separate issue for the mqpacker proposal. https://codereview.adblockplus.org/29441585/diff/29441586/README.md File README.md (right): https://codereview.adblockplus.org/29441585/diff/29441586/README.md#newcode37 ...
2 months, 3 weeks ago (2017-05-30 10:10:48 UTC) #12
ire
On 2017/05/30 10:10:48, juliandoucette wrote: > Please open a separate issue for the mqpacker proposal. ...
2 months, 3 weeks ago (2017-05-30 10:17:56 UTC) #13
juliandoucette
@Thomas can you please LGTM or not for UI module so that we can close ...
1 month, 1 week ago (2017-07-14 12:16:43 UTC) #14
Thomas Greiner
On 2017/07/14 12:16:43, juliandoucette wrote: > @Thomas can you please LGTM or not for UI ...
1 month, 1 week ago (2017-07-14 12:19:18 UTC) #15
juliandoucette
On 2017/07/14 12:19:18, Thomas Greiner wrote: Thanks Thomas :) Can you please close this Ire?
4 weeks ago (2017-07-25 13:49:51 UTC) #16
ire
4 weeks ago (2017-07-25 14:06:15 UTC) #17
On 2017/07/25 13:49:51, juliandoucette wrote:
> Can you please close this Ire?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5