Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: pages/filter-lists-requirements.html

Issue 29442555: Issue 4934 - Add 'Requirements for Adblock Plus recommended filter lists' page to adblockplus.org (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Created May 19, 2017, 5:09 a.m.
Right Patch Set: Addressed NITs Created Sept. 7, 2017, 9:47 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « pages/contribute.html ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Recommended filter list requirements 1 title=Recommended filter list requirements
2 description=A filter list must meet certain requirements in order to be recommen ded to users by Adblock Plus. 2 description=A filter list must meet certain requirements in order to be recommen ded to users by Adblock Plus.
3 3
4 <p>{{ filter-lists-requirements-intro[Filter Lists Requirements Intro] The list: }}</p> 4 <p>{{filter-lists-requirements-intro[Filter Lists Requirements Intro] The list:} }</p>
juliandoucette 2017/05/30 12:55:02 NIT: Please remove spaces before string IDs ( PS:
ire 2017/06/28 09:59:55 Done.
5 5
6 <ul> 6 <ul>
7 <li> 7 <li>
8 {{ filter-lists-requirements-item[Filter Lists Requirements List Item] S hould be open source and have the possibility for users to report issues/suggest filters }} 8 {{filter-lists-requirements-item-1[Filter Lists Requirements List Item] Should be open source and have the possibility for users to report issues/sugges t filters}}
9 </li> 9 </li>
10 10
11 <li> 11 <li>
12 {{ filter-lists-requirements-item2[Filter Lists Requirements List Item] Must be unique (does not duplicate another list or filters in another list) }} 12 {{filter-lists-requirements-item-2[Filter Lists Requirements List Item] Must be unique (does not duplicate another list or filters in another list)}}
13 <ul> 13 <ul>
14 <li> 14 <li>
15 {{ filter-lists-requirements-item2-example[Filter Lists Requirem ents List Item] Example: we will not support a second German filter list, or a l ist that has filters already contained in EasyList (i.e. do not create another EasyList Germany if it does not include additional or better filters) }} 15 {{filter-lists-requirements-item-2-example[Filter Lists Requirem ents List Item] Example: we will not support a second German filter list, or a l ist that has filters already contained in <fix>EasyList</fix> (i.e. do not creat e another "<fix>EasyList</fix> Germany" if it does not include additional or bet ter filters)}}
juliandoucette 2017/05/30 12:55:03 NIT: Missing <fix> around EasyList
ire 2017/06/28 09:59:56 Done.
16 </li> 16 </li>
17 </ul> 17 </ul>
18 </li> 18 </li>
19 19
20 <li> 20 <li>
21 {{ filter-lists-requirements-item3[Filter Lists Requirements List Item] Must meet a certain quality }} 21 {{filter-lists-requirements-item-3[Filter Lists Requirements List Item] Must meet a certain quality}}
22 <ul> 22 <ul>
23 <li> 23 <li>
24 {{ filter-lists-requirements-item3-example[Filter Lists Requirem ents List Item] Example: should have no redundancy, no extremely generic filters , no <a href="https://adblockplus.org/forum/viewtopic.php?t=6118">slow filters </a> }} 24 {{filter-lists-requirements-item-3-example[Filter Lists Requirem ents List Item] Example: should have no redundancy, no extremely generic filters , no <a href="https://adblockplus.org/forum/viewtopic.php?t=6118">"slow" filters </a>}}
juliandoucette 2017/05/30 12:55:03 NIT: Please replace angled commas and quotes
ire 2017/06/28 09:59:56 Done.
25 </li> 25 </li>
26 </ul> 26 </ul>
27 </li> 27 </li>
28 28
29 <li> 29 <li>
30 {{ filter-lists-requirements-item4[Filter Lists Requirements List Item] Must comply with certain minimum standards, as stated in the <a href="https://ea sylist.to/pages/policy.html">EasyList policy</a> }} 30 {{filter-lists-requirements-item-4[Filter Lists Requirements List Item] Must comply with certain minimum standards, as stated in the <a href="https://ea sylist.to/pages/policy.html"><fix>EasyList</fix> policy</a>}}
31 </li> 31 </li>
32 32
33 <li> 33 <li>
34 {{ filter-lists-requirements-item5[Filter Lists Requirements List Item] Must block only ads }} 34 {{filter-lists-requirements-item-5[Filter Lists Requirements List Item] Must block only ads}}
35 <ul> 35 <ul>
36 <li> 36 <li>
37 {{ filter-lists-requirements-item5-example[Filter Lists Requirem ents List Item] Example: it shouldn’t block non-ads, i.e. content, or self-promo tion, and it must not work around anti-ad block warnings and messages or technol ogical measures that effectively control access to websites. }} 37 {{filter-lists-requirements-item-5-example[Filter Lists Requirem ents List Item] Example: it shouldn’t block non-ads, i.e. content, or self-promo tion, and it must not work around anti-ad block warnings and messages or technol ogical measures that effectively control access to websites.}}
38 </li> 38 </li>
39 </ul> 39 </ul>
40 </li> 40 </li>
41 41
42 <li> 42 <li>
43 {{ filter-lists-requirements-item6[Filter Lists Requirements List Item] Must be actively maintained. }} 43 {{filter-lists-requirements-item-6[Filter Lists Requirements List Item] Must be actively maintained.}}
44 </li> 44 </li>
45 45
46 <li> 46 <li>
47 {{ filter-lists-requirements-item7[Filter Lists Requirements List Item] Finally, the filter list author must have a proficient understanding of the lang uage he/she is creating the list for. }} 47 {{filter-lists-requirements-item-7[Filter Lists Requirements List Item] Finally, the filter list author must have a proficient understanding of the lang uage he/she is creating the list for.}}
48 </li> 48 </li>
49 </ul> 49 </ul>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld