Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(479)

Issue 29442622: Noissue - move (UpdaterTest, SetRemoveUpdateAvailableCallback) to UpdateCheck.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by sergei
Modified:
1 month ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

test (UpdaterTest, ForceUpdateCheck) is even removed because it duplicates tests in UpdateCheck.cpp review: https://codereview.adblockplus.org/29442622 #depends on https://codereview.adblockplus.org/29442619/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -79 lines) Patch
M test/FilterEngine.cpp View 2 chunks +0 lines, -79 lines 0 comments Download
M test/UpdateCheck.cpp View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sergei
1 month ago (2017-05-19 16:50:06 UTC) #1
hub
1 month ago (2017-05-19 17:06:26 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5