Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(486)

Issue 29442626: Noissue - remove JsEngine as a member of UpdateCheckTest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by sergei
Modified:
1 month ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

review: https://codereview.adblockplus.org/29442626 # it's noissue and the change can be a bit questionable, though the idea that owing of JsEngine should be changed appeared a couple of times in different places, e.g. #4693 and #5198.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M test/UpdateCheck.cpp View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2
sergei
1 month ago (2017-05-19 16:57:06 UTC) #1
hub
1 month ago (2017-05-19 17:07:19 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5