Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1855)

Issue 29442722: Issue 3593 - stop sharing v8::Isolate among tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by sergei
Modified:
4 months, 3 weeks ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# The diff seems correct but side-by-side view is broken, and any attempt to submit it fails.

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Patch Set 3 : address comments and rebase #

Total comments: 5

Patch Set 4 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M include/AdblockPlus/JsEngine.h View 1 2 4 chunks +4 lines, -10 lines 0 comments Download
M src/JsEngine.cpp View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M test/BaseJsTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M test/JsEngine.cpp View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11
sergei
5 months ago (2017-05-19 17:35:29 UTC) #1
hub
https://codereview.adblockplus.org/29442722/diff/29442723/test/JsEngine.cpp File test/JsEngine.cpp (right): https://codereview.adblockplus.org/29442722/diff/29442723/test/JsEngine.cpp#newcode206 test/JsEngine.cpp:206: I am not convinced by this test. We run ...
5 months ago (2017-05-19 19:20:21 UTC) #2
sergei
https://codereview.adblockplus.org/29442722/diff/29442723/test/JsEngine.cpp File test/JsEngine.cpp (right): https://codereview.adblockplus.org/29442722/diff/29442723/test/JsEngine.cpp#newcode206 test/JsEngine.cpp:206: On 2017/05/19 19:20:21, hub wrote: > I am not ...
5 months ago (2017-05-22 08:08:55 UTC) #3
hub
On 2017/05/22 08:08:55, sergei wrote: > https://codereview.adblockplus.org/29442722/diff/29442723/test/JsEngine.cpp > File test/JsEngine.cpp (right): > > https://codereview.adblockplus.org/29442722/diff/29442723/test/JsEngine.cpp#newcode206 > ...
5 months ago (2017-05-23 14:08:13 UTC) #4
sergei
https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp File test/JsEngine.cpp (right): https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp#newcode200 test/JsEngine.cpp:200: #if UINTPTR_MAX == UINT32_MAX // detection of 32-bit platform ...
4 months, 4 weeks ago (2017-05-24 16:22:32 UTC) #5
hub
https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp File test/JsEngine.cpp (right): https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp#newcode200 test/JsEngine.cpp:200: #if UINTPTR_MAX == UINT32_MAX // detection of 32-bit platform ...
4 months, 4 weeks ago (2017-05-24 16:31:40 UTC) #6
sergei
https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp File test/JsEngine.cpp (right): https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp#newcode200 test/JsEngine.cpp:200: #if UINTPTR_MAX == UINT32_MAX // detection of 32-bit platform ...
4 months, 4 weeks ago (2017-05-24 17:05:51 UTC) #7
hub
https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp File test/JsEngine.cpp (right): https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp#newcode200 test/JsEngine.cpp:200: #if UINTPTR_MAX == UINT32_MAX // detection of 32-bit platform ...
4 months, 4 weeks ago (2017-05-24 18:18:07 UTC) #8
sergei
https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp File test/JsEngine.cpp (right): https://codereview.adblockplus.org/29442722/diff/29447563/test/JsEngine.cpp#newcode200 test/JsEngine.cpp:200: #if UINTPTR_MAX == UINT32_MAX // detection of 32-bit platform ...
4 months, 3 weeks ago (2017-05-26 10:56:43 UTC) #9
sergei
BTW, I'm also preparing changes with updating of v8 for uploading and had to disable ...
4 months, 3 weeks ago (2017-05-26 11:12:55 UTC) #10
hub
4 months, 3 weeks ago (2017-05-26 12:01:25 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5