Issue 3593 - stop sharing v8::Isolate among tests

test/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 170 matching lines @@
 
 TEST(NewJsEngineTest, GlobalPropertyTest)
 {
   AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
   jsEngine->SetGlobalProperty("foo", jsEngine->NewValue("bar"));
   auto foo = jsEngine->Evaluate("foo");
   ASSERT_TRUE(foo.IsString());
   ASSERT_EQ(foo.AsString(), "bar");
 }
 
+TEST(NewJsEngineTest, MemoryLeak_NoCircularReferences)
+{
+  std::weak_ptr<AdblockPlus::JsEngine> weakJsEngine;
+  {
+    weakJsEngine = AdblockPlus::JsEngine::New();
+  }
+  EXPECT_FALSE(weakJsEngine.lock());
+}
+
+TEST(NewJsEngineTest, MemoryLeak_NoLeak)
+{
+  // v8::Isolate by default requires 32MB (depends on platform), so if there is
+  // a memory leak than we will run out of memory on 32 bit platform because it
+  // will allocate 32000 MB which is less than 2GB where it reaches out of
+  // memory. Even on android where it allocates initially 16MB, the test still
+  // makes sense.
+  for (int i = 0; i < 1000; ++i)
+  {
+    AdblockPlus::JsEngine::New();
+  }
+}