Unified Diff: test/BaseJsTest.cpp
Issue 29442722:
Issue 3593 - stop sharing v8::Isolate among tests (Closed)
Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: address comments and rebase
Created May 24, 2017, 4:20 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/JsEngine.cpp ('k')
|
test/JsEngine.cpp » ('j')
|
test/JsEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/BaseJsTest.cpp |
| diff --git a/test/BaseJsTest.cpp b/test/BaseJsTest.cpp |
| index 2dedd79ad5353e6aed84716fc82f725d35f67983..0f94f08f8131f7b9f3f6d8ad13d975cd5749f9d5 100644 |
| --- a/test/BaseJsTest.cpp |
| +++ b/test/BaseJsTest.cpp |
| @@ -42,11 +42,9 @@ JsEngineCreationParameters::JsEngineCreationParameters() |
| AdblockPlus::JsEnginePtr CreateJsEngine(JsEngineCreationParameters&& jsEngineCreationParameters) |
| { |
| - static AdblockPlus::ScopedV8IsolatePtr isolate = std::make_shared<AdblockPlus::ScopedV8Isolate>(); |
| auto jsEngine = AdblockPlus::JsEngine::New(jsEngineCreationParameters.appInfo, |
| std::move(jsEngineCreationParameters.timer), |
| - std::move(jsEngineCreationParameters.webRequest), |
| - isolate); |
| + std::move(jsEngineCreationParameters.webRequest)); |
| jsEngine->SetLogSystem(std::move(jsEngineCreationParameters.logSystem)); |
| jsEngine->SetFileSystem(std::move(jsEngineCreationParameters.fileSystem)); |
| return jsEngine; |
« no previous file with comments
|
« src/JsEngine.cpp ('k')
|
test/JsEngine.cpp » ('j')
|
test/JsEngine.cpp » ('J')
