Issue 5223 - App is freezing sometimes

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 171 matching lines @@
     }
     catch (PackageManager.NameNotFoundException e)
     {
       // Should never happen, as checkAAStatusAndProceed() should not be called if the user
       // has no compatible SBrowser installed. Nevertheless we have to handle the Exception.
       Log.d(TAG, "No compatible Samsung Browser found.", e);
       return false;
     }
   }
 
-  public void setSubscriptionUpdateCallback(final SubscriptionUpdateCallback subscriptionUpdateCallback) {
+  public void setSubscriptionUpdateCallback(final SubscriptionUpdateCallback subscriptionUpdateCallback)
+  {
     this.subscriptionUpdateCallback = subscriptionUpdateCallback;
   }
 
   public void requestUpdateBroadcast()
   {
     this.nextUpdateBroadcast = System.currentTimeMillis() + BROADCAST_COMBINATION_DELAY_MILLIS;
   }
 
   private void writeFileAndSendUpdateBroadcast()
   {
@@ skipping 49 matching lines @@
 
   public List<SubscriptionInfo> getListedSubscriptions()
   {
     return this.subscriptions.getSubscriptions(this);
   }
 
   public void changeSubscriptionState(final String id, final boolean enabled)
   {
     if (this.subscriptionUpdateCallback != null)
     {
-      this.subscriptionUpdateCallback.subscriptionUpdateRequested();
+      this.subscriptionUpdateCallback.subscriptionUpdateRequested(enabled);
     }
     this.engineEvents.add(new ChangeEnabledStateEvent(id, enabled));
   }
 
   public void subscriptionStateChanged() {

[anton, 2017/06/26 14:45:54]

"{" should be on the next line.
LGTM in general

     if (this.subscriptionUpdateCallback != null)
     {
       this.subscriptionUpdateCallback.subscriptionUpdatedApplied();
     }
   }
 
   void downloadFinished(final String id, final int responseCode, final String response,
       final Map<String, String> headers)
   {
     this.engineEvents.add(new DownloadFinishedEvent(id, responseCode, response, headers));
@@ skipping 521 matching lines @@
       Log.d(TAG, headers.toString());
       this.downloader.enqueueDownload(this.createDownloadURL(sub), sub.getId(), headers);
     }
   }
 
   public void connectivityChanged()
   {
     this.downloader.connectivityChanged();
   }
 
-  public interface SubscriptionUpdateCallback {
-    void subscriptionUpdateRequested();
+  public interface SubscriptionUpdateCallback
+  {
+    void subscriptionUpdateRequested(boolean enabled);
     void subscriptionUpdatedApplied();
   }
 }