Issue 5223 - App is freezing sometimes

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 236 matching lines @@
       if (this.dialogTitleResId == R.string.setup_dialog_title)
       {
         this.dismissDialog();
       }
     }
   }
 
   @Override
   public void subscriptionUpdateRequested(final boolean enabled)
   {
     this.dialog = ProgressDialog.show(this, null, enabled ?

[anton, 2017/06/26 14:45:54]

would it not be better to have it like this ".. enabled
  ? ..
  : .."

not insisting though

         getString(R.string.add_subscription_dialog_message) : getString(R.string.remove_subscription_dialog_message));
   }
 
   @Override
   public void subscriptionUpdatedApplied()
   {
-    if (dialog != null)
-    {
-      dialog.dismiss();

[anton, 2017/06/26 13:49:34]

don't we need to `dialog = null` after it's dismissed?

[jens, 2017/06/26 14:05:20]

Yeah, you're right. I think it's cleaner. I will use the dismissDialog() method
already exists.

-    }
+    this.dismissDialog();
   }
 }