Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: new-options.html

Issue 29445590: Issue 5255 - Advanced tab (HTML, strings and functionality) (Closed)
Patch Set: Addressed Thomas comments Created July 14, 2017, 5:09 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« locale/en-US/new-options.json ('K') | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | new-options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2017 eyeo GmbH 4 - Copyright (C) 2006-2017 eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 aria-selected="true" aria-controls="content-general" 46 aria-selected="true" aria-controls="content-general"
47 tabindex="0"> 47 tabindex="0">
48 <span class="i18n_options_tab_general"></span> 48 <span class="i18n_options_tab_general"></span>
49 </li> 49 </li>
50 <li id="tab-whitelist" role="tab" data-tab="whitelist" 50 <li id="tab-whitelist" role="tab" data-tab="whitelist"
51 aria-controls="content-whitelist" 51 aria-controls="content-whitelist"
52 tabindex="-1"> 52 tabindex="-1">
53 <span class="i18n_options_tab_whitelist"></span> 53 <span class="i18n_options_tab_whitelist"></span>
54 </li> 54 </li>
55 <li id="tab-advanced" role="tab" data-tab="advanced" 55 <li id="tab-advanced" role="tab" data-tab="advanced"
56 data-subtab="advanced-allFilterLists"
57 aria-controls="content-advanced" tabindex="-1"> 56 aria-controls="content-advanced" tabindex="-1">
58 <span class="i18n_options_tab_advanced"></span> 57 <span class="i18n_options_tab_advanced"></span>
59 </li> 58 </li>
60 <li id="tab-help" role="tab" data-tab="help" 59 <li id="tab-help" role="tab" data-tab="help"
61 aria-controls="content-help" tabindex="-1"> 60 aria-controls="content-help" tabindex="-1">
62 <span class="i18n_options_tab_help"></span> 61 <span class="i18n_options_tab_help"></span>
63 </li> 62 </li>
64 </ul> 63 </ul>
65 </nav> 64 </nav>
66 65
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 title="options_control_remove_title"> 188 title="options_control_remove_title">
190 </button> 189 </button>
191 </template> 190 </template>
192 </ul> 191 </ul>
193 </div> 192 </div>
194 193
195 <!-- Advanced tab content --> 194 <!-- Advanced tab content -->
196 <div id="content-advanced" role="tabpanel" 195 <div id="content-advanced" role="tabpanel"
197 aria-labelledby="tab-advanced"> 196 aria-labelledby="tab-advanced">
198 <div> 197 <div>
199 <h1 class="i18n_options_tweaks_title"></h1> 198 <h1 class="i18n_options_tab_advanced"></h1>
200 <ul id="tweaks" class="table"> 199 <p class="i18n_options_advanced_description"></p>
201 <li data-pref="shouldShowBlockElementMenu"> 200 <section>
202 <label> 201 <h2 class="i18n_options_customize_header"></h2>
203 <button role="checkbox" data-action="toggle-pref"></button> 202 <ul id="customize" class="table">
204 <span class="i18n_options_tweaks_blockElement"></span> 203 <li data-pref="shouldShowBlockElementMenu">
205 </label> 204 <label>
206 </li> 205 <button role="checkbox" data-action="toggle-pref"></button>
207 <li data-pref="show_devtools_panel"> 206 <span class="i18n_options_customize_blockElement"></span>
208 <label> 207 <span class="i18n_options_readMore"
209 <button role="checkbox" data-action="toggle-pref"></button> 208 data-tooltip="options_customize_blockElement_tooltip"></sp an>
210 <span class="i18n_options_tweaks_showDevToolsPanel"></span> 209 </label>
211 </label> 210 </li>
212 </li> 211 <li data-pref="show_devtools_panel">
213 <li data-pref="notifications_ignoredcategories"> 212 <label>
214 <label> 213 <button role="checkbox" data-action="toggle-pref"></button>
215 <button role="checkbox" data-action="toggle-pref"></button> 214 <span class="i18n_options_customize_showDevToolsPanel"></spa n>
216 <span class="i18n_options_tweaks_showNotifications"></span> 215 <span class="i18n_options_readMore"
217 </label> 216 data-tooltip="options_customize_showDevToolsPanel_tooltip" ></span>
218 </li> 217 </label>
219 </ul> 218 </li>
219 <li data-pref="notifications_ignoredcategories">
220 <label>
221 <button role="checkbox" data-action="toggle-pref"></button>
222 <span class="i18n_options_customize_showNotifications"></spa n>
223 <span class="i18n_options_readMore"
224 data-tooltip="options_customize_showNotifications_tooltip" ></span>
225 </label>
226 </li>
227 </ul>
228 </section>
220 </div> 229 </div>
221 230
222 <div> 231 <section>
223 <h1> 232 <h1 class="i18n_options_filterList_title"></h1>
224 <span class="i18n_options_filterList_title"></span> 233 <p id="filter-lists-description" class="i18n_options_filterList_desc ription"></p>
225 <span class="i18n_options_readMore" 234
226 data-tooltip="options_filterList_title_tooltip"></span> 235 <div id="all-filter-lists-table-header">
227 </h1> 236 <h2 class="i18n_options_filterList_column_status"></h2>
228 <ul class="tabs horizontal" role="tablist" data-action="switch-tab" 237 <h2 class="i18n_options_filterList_column_name"></h2>
229 data-keys="ArrowLeft ArrowUp ArrowRight ArrowDown"> 238 <h2 class="i18n_options_filterList_column_update"></h2>
230 <li id="tab-allFilterLists" 239 </div>
231 class="i18n_options_tab_overview active" 240 <ul class="table cols" id="all-filter-lists-table">
232 role="tab" data-tab="advanced-allFilterLists" 241 <template>
233 aria-selected="true" aria-controls="all-filter-lists" 242 <button data-action="remove-subscription" class="control delete" ></button>
234 tabindex="0"></li> 243 <button data-action="toggle-disable-subscription" role="checkbox " class="control">
235 <li id="tab-customFilters" class="i18n_options_tab_ownList" 244 </button>
236 role="tab" data-tab="advanced-customFilters" 245 <div class="state">
237 aria-controls="custom-filters" tabindex="-1"></li> 246 <span class="i18n_options_filterList_state_active" id="state-a ctive"></span>
238 </ul> 247 <span class="i18n_options_filterList_state_disabled" id="state -disabled"></span>
239 <div id="filter-lists">
240 <div id="all-filter-lists" role="tabpanel"
241 aria-labelledby="tab-allFilterLists">
242 <div class="table-header">
243 <h2 class="i18n_options_column_name"></h2>
244 <h2 class="i18n_options_column_date"></h2>
245 </div> 248 </div>
246 <ul class="table cols" id="all-filter-lists-table"> 249 <div>
247 <template> 250 <label class="display"></label>
248 <button data-action="toggle-disable-subscription" role="chec kbox" class="control"></button>
249 <div>
250 <label data-action="open-context-menu" class="display"></l abel>
251 <div data-action="open-context-menu" class="arrow">
252 <div class="context-menu">
253 <div class="content">
254 <a class="i18n_options_filterList_updateNow update-s ubscription" data-action="update-subscription"></a>
255 <a class="i18n_options_filterList_website website" t arget="_blank"></a>
256 <a class="i18n_options_filterList_source source" tar get="_blank"></a>
257 <a class="i18n_options_filterList_delete delete" dat a-action="remove-subscription"></a>
258 </div>
259 </div>
260 </div>
261 </div>
262 <span class="date"></span>
263 <span class="time"></span>
264 <span class="message"></span>
265 </template>
266 <li class="static">
267 <button id="own-list" role="checkbox" class="control" aria-c hecked="true" disabled="true"></button>
268 <div>
269 <label for="own-list" class="i18n_options_filterList_own_l ist"></label>
270 </div>
271 <span>
272 <a class="i18n_options_filterList_edit_own_list"
273 href="#advanced-customFilters"></a>
274 </span>
275 </li>
276 </ul>
277 <div class="controls">
278 <button data-action="open-dialog" data-dialog="custom">
279 <span class="icon icon-add"></span>
280 <span class="i18n_options_filterList_add"></span>
281 </button>
282 <button data-action="update-all-subscriptions">
283 <span class="icon icon-update"></span>
284 <span class="i18n_options_filterList_update"></span>
285 </button>
286 </div> 251 </div>
287 </div> 252 <span class="last-update"></span>
288 <div id="custom-filters" role="tabpanel" 253 <span class="message"></span>
289 aria-labelledby="tab-customFilters"> 254 <a data-action="open-context-menu" class="arrow"></a>
290 <h2 id="custom-filters-header"> 255 <div role="menubar" class="context-menu-wrapper">
291 <span class="i18n_options_customFilters_title"></span> 256 <div class="context-menu">
292 <span class="i18n_options_readMore" 257 <ul class="content" role="menu">
293 data-tooltip="options_customFilters_title_tooltip"></span> 258 <li role="menuitem">
294 </h2> 259 <a class="i18n_options_filterList_updateNow update-subsc ription" data-action="update-subscription"></a>
295 <div id="custom-filters-wrapper"> 260 </li>
296 <div id="custom-filters-list-wrapper"> 261 <li role="menuitem">
297 <ul id="custom-filters-table" class="table list"> 262 <a class="i18n_options_filterList_website website" targe t="_blank"></a>
298 <template> 263 </li>
299 <label class="display"></label> 264 <li role="menuitem">
300 </template> 265 <a class="i18n_options_filterList_source source" target= "_blank"></a>
266 </li>
267 <li role="menuitem">
268 <a class="i18n_options_filterList_delete delete" data-ac tion="remove-subscription"></a>
269 </li>
301 </ul> 270 </ul>
302 <form id="custom-filters-add" class="controls">
303 <input type="text"/>
304 <button class="i18n_options_button_add" type="submit"></bu tton>
305 </form>
306 </div>
307 <textarea id="custom-filters-raw"></textarea>
308 </div>
309 <div id="custom-filters-edit-wrapper" class="controls">
310 <button id="custom-filters-show-edit" data-action="edit-custom -filters">
311 <span class="icon icon-edit"></span>
312 <span class="i18n_options_customFilter_edit"></span>
313 </button>
314 <div id="custom-filters-raw-controls">
315 <button id="custom-filters-raw-save" data-action="save-custo m-filters">
316 <span class="icon icon-save"></span>
317 <span class="i18n_options_customFilter_save"></span>
318 </button>
319 <button data-action="cancel-custom-filters">
320 <span class="icon icon-cancel"></span>
321 <span class="i18n_options_customFilter_cancel"></span>
322 </button>
323 </div> 271 </div>
324 </div> 272 </div>
273 </template>
274 </ul>
275 <div class="controls">
276 <button data-action="open-dialog" data-dialog="custom">
277 <span class="icon icon-add"></span>
278 <span class="i18n_options_filterList_add"></span>
279 </button>
280 <button data-action="update-all-subscriptions">
281 <span class="icon icon-update"></span>
282 <span class="i18n_options_filterList_update"></span>
283 </button>
284 </div>
285 </section>
286
287 <section>
288 <h1 class="i18n_options_customFilters_title"></h1>
289 <p class="i18n_options_customFilters_description"></p>
290 <h2 class="i18n_options_customFilters_widget_title"></h2>
291 <div id="custom-filters">
292 <div id="empty-custom-filters">
293 <p class="i18n_options_customFilters_tip"></p>
294 <button class="i18n_options_customFilters_start" data-action="ed it-custom-filters">
295 </button>
296 <p>
297 <a class="i18n_options_customFilters_learn" id="link-filters" target="_blank"></a>
298 </p>
299 </div>
300 <textarea id="custom-filters-raw" rows="15"></textarea>
301 <button id="custom-filters-edit" class="i18n_options_customFilter_ edit" data-action="edit-custom-filters">
302 </button>
303 <div id="custom-filters-raw-controls">
304 <button class="i18n_options_customFilter_save" data-action="save -custom-filters">
305 </button>
306 <button class="i18n_options_customFilter_cancel" data-action="ca ncel-custom-filters">
307 </button>
325 </div> 308 </div>
326 </div> 309 </div>
327 </div> 310 </section>
328 </div> 311 </div>
329 312
330 <!-- Help tab content --> 313 <!-- Help tab content -->
331 <div id="content-help" role="tabpanel" aria-labelledby="tab-help"> 314 <div id="content-help" role="tabpanel" aria-labelledby="tab-help">
332 <h1 class="i18n_options_faq_title"></h1> 315 <h1 class="i18n_options_faq_title"></h1>
333 <p class="i18n_options_faq_description"></p> 316 <p class="i18n_options_faq_description"></p>
334 <p> 317 <p>
335 <a id="link-faq" class="i18n_options_faq_title" target="_blank"></a > 318 <a id="link-faq" class="i18n_options_faq_title" target="_blank"></a >
336 </p> 319 </p>
337 <h1 class="i18n_options_forum_title"></h1> 320 <h1 class="i18n_options_forum_title"></h1>
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 <div id="dialog-content-custom" class="dialog-content"> 379 <div id="dialog-content-custom" class="dialog-content">
397 <div class="dialog-content-block"> 380 <div class="dialog-content-block">
398 <div> 381 <div>
399 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label> 382 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label>
400 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" /> 383 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" />
401 </div> 384 </div>
402 <button class="i18n_options_dialog_custom_import" data-action="impor t-subscription"></button> 385 <button class="i18n_options_dialog_custom_import" data-action="impor t-subscription"></button>
403 </div> 386 </div>
404 <div class="dialog-content-block"> 387 <div class="dialog-content-block">
405 <h3 class="i18n_options_dialog_edit_own_list"></h3> 388 <h3 class="i18n_options_dialog_edit_own_list"></h3>
406 <button class="i18n_options_dialog_create_own_list" data-action="clo se-dialog,switch-tab,edit-custom-filters" data-tab="advanced-customFilters"></bu tton> 389 <button class="i18n_options_dialog_create_own_list" data-action="clo se-dialog,switch-tab,edit-custom-filters" data-tab="advanced"></button>
407 </div> 390 </div>
408 </div> 391 </div>
409 <!-- Add predefined subscription --> 392 <!-- Add predefined subscription -->
410 <div id="dialog-content-predefined" class="dialog-content"> 393 <div id="dialog-content-predefined" class="dialog-content">
411 <div class="dialog-content-block"> 394 <div class="dialog-content-block">
412 <h3></h3> 395 <h3></h3>
413 <div class="url"></div> 396 <div class="url"></div>
414 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 397 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
415 </div> 398 </div>
416 </div> 399 </div>
417 </div> 400 </div>
418 <!-- Placeholder element to determine when to wrap focus around --> 401 <!-- Placeholder element to determine when to wrap focus around -->
419 <span class="focus-last" tabindex="0"></span> 402 <span class="focus-last" tabindex="0"></span>
420 </div> 403 </div>
421 </body> 404 </body>
422 </html> 405 </html>
OLDNEW
« locale/en-US/new-options.json ('K') | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | new-options.js » ('J')

Powered by Google App Engine
This is Rietveld