Issue 5255 - Advanced tab (HTML, strings and functionality)

skin/new-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 329 matching lines @@
   position: relative;
 }
 
 #content-wrapper > div
 {
   display: none;
 }
 
 body[data-tab|="general"] #content-general,
 body[data-tab|="advanced"] #content-advanced,
+body[data-tab|="whitelist"] #content-whitelist,
 body[data-tab|="help"] #content-help
 {
   display: block;
 }
 
 div.button
 {
   cursor: pointer;
   display: flex;
 }
@@ skipping 30 matching lines @@
   white-space: nowrap;
 }
 
 .table:not(.list):not(.cols) li
 {
   padding-top: 0px;
   padding-bottom: 6px;
 }
 
 .table.list li:nth-of-type(odd),
-.table.cols li:nth-of-type(odd),
+.table.cols li:nth-of-type(odd):not([role="menuitem"]),
 .table li.empty-placeholder
 {
   background-color: #F5F5F5;
 }
 
 .table label
 {
   vertical-align: top;
 }
 
 .table.cols
 {
   border-bottom: 1px solid #CDCDCD;
   border-top: 1px solid #CDCDCD;
 }
 
-button[disabled="true"]
+button[role="checkbox"][disabled]
 {
   border-radius: 2px;
   background-color: #ccc;
 }
 
 .table button.delete
 {
   background-color: transparent;
   background-position: -50px -51px;
   border: 0px;
@@ skipping 128 matching lines @@
 {
   height: 290px;
   overflow: auto;
 }
 
 #custom-wrapper .table
 {
   width: 100%;
 }
 
-#whitelisting .controls.mode-edit > button,
-#whitelisting .controls:not(.mode-edit) > div
-{
-  display: none;
-}
-
-#whitelisting .controls input[type="text"]
-{
-  border: 0px;
-  border-bottom: 1px solid #A1A1A1;
-  -moz-padding-end: 25px;
-  -webkit-padding-end: 25px;
-  -moz-margin-start: 14px;
-  -webkit-margin-start: 14px;
-  outline: 0px;
-  padding-bottom: 5px;
-  vertical-align: text-bottom;
-  width: 100%;
-}
-
-#whitelisting .controls .button-add span
-{
-  -moz-margin-start: 5px;
-  -webkit-margin-start: 5px;
-}
-
-#whitelisting .button-add
-{
-  -moz-margin-start: 32px;
-  -webkit-margin-start: 32px;
-}
-
-#whitelisting-add-button + span
-{
-  flex: 1;
-}
-
-.icon-enter
-{
-  background-position: -19px -33px;
-  position: absolute;
-  bottom: 9px;
-  -moz-margin-start: -20px;
-  -webkit-margin-start: -20px;
-}
-
-.button-add, .cancel-button
+.button-add
 {
   background-color: transparent;
   border: 0px;
   color: #3A7BA6;
   cursor: pointer;
 }
 
 /*
   Advanced tab content
 */
 
 #all-filter-lists-table li.show-message .last-update,
 #all-filter-lists-table li:not(.show-message) .message,
-#custom-filters:not(.mode-empty) #empty-custom-filters,
-#custom-filters:not(.mode-edit) #custom-filters-raw,
-#custom-filters:not(.mode-edit) #custom-filters-raw-controls,
-#custom-filters:not(.mode-view) #custom-filters-box,
-#custom-filters:not(.mode-view) #custom-filters-edit,
+#custom-filters:not([data-mode="empty"]) #empty-custom-filters,
+#custom-filters[data-mode="empty"] #custom-filters-raw,
+#custom-filters:not([data-mode="write"]) #custom-filters-raw-controls,
+#custom-filters:not([data-mode="read"]) #custom-filters-edit,
 .state span
 {
   display: none;
 }
 
 #all-filter-lists-table
 {
   display: inline-block;
 }
 
@@ skipping 46 matching lines @@
 {
   color: #3A7BA6;
   text-decoration: none;
   cursor: pointer;
 }
 
 #all-filter-lists-table li:last-of-type > span:last-child
 {
   -webkit-margin-start: auto;
   -moz-margin-start: auto;
-}
-
-#all-filter-lists-table .static label

[Thomas Greiner, 2017/07/07 13:01:11]

Detail: You removed the only element with the "static" class so it seems that we
can remove this now.

[saroyanm, 2017/07/10 11:38:02]

Well spotted. 

[saroyanm, 2017/07/12 15:29:03]

Done.

-{
-  font-weight: 600;
 }
 
 #custom-filters-raw-controls
 {
   justify-content: space-between;
 }
 
 #custom-filters-raw
 {
   width: 100%;
@@ skipping 448 matching lines @@
 #other-language .button-add::before
 {
   display: none;
 }
 
 #other-language .display
 {
   -webkit-margin-start: 10px;
   -moz-margin-start: 10px;
 }