Issue 5183 - Provide async interface for FileSystem

test/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 154 matching lines @@
 TEST(NewJsEngineTest, CallbackGetSet)
 {
   AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
 
   ASSERT_TRUE(jsEngine->GetLogSystem());
   ASSERT_ANY_THROW(jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr()));
   AdblockPlus::LogSystemPtr logSystem(new AdblockPlus::DefaultLogSystem());
   jsEngine->SetLogSystem(logSystem);
   ASSERT_EQ(logSystem, jsEngine->GetLogSystem());
 
-  ASSERT_TRUE(jsEngine->GetFileSystem());
-  ASSERT_ANY_THROW(jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr()));
-  AdblockPlus::FileSystemPtr fileSystem(new AdblockPlus::DefaultFileSystem());
-  jsEngine->SetFileSystem(fileSystem);
-  ASSERT_EQ(fileSystem, jsEngine->GetFileSystem());
+  ASSERT_TRUE(jsEngine->GetAsyncFileSystem());

[sergei, 2017/07/05 10:03:21]

Since it's a private functionality, I think we can remove this line from tests.

[hub, 2017/07/06 12:21:52]

Done.

 }
 
 TEST(NewJsEngineTest, GlobalPropertyTest)
 {
   AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
   jsEngine->SetGlobalProperty("foo", jsEngine->NewValue("bar"));
   auto foo = jsEngine->Evaluate("foo");
   ASSERT_TRUE(foo.IsString());
   ASSERT_EQ(foo.AsString(), "bar");
 }
@@ skipping 16 matching lines @@
 {
   // v8::Isolate by default requires 32MB (depends on platform), so if there is
   // a memory leak than we will run out of memory on 32 bit platform because it
   // will allocate 32000 MB which is less than 2GB where it reaches out of
   // memory. Even on android where it allocates initially 16MB, the test still
   // makes sense.
   for (int i = 0; i < 1000; ++i)
   {
     AdblockPlus::JsEngine::New();
   }
-}
+}