Issue 5183 - Provide async interface for FileSystem

src/FileSystemJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 29 matching lines @@
       return ThrowExceptionInJS(isolate, "_fileSystem.read requires 2 parameters");
     if (!converted[1].IsFunction())
       return ThrowExceptionInJS(isolate, "Second argument to _fileSystem.read must be a function");
 
     JsValueList values;
     values.push_back(converted[1]);
     auto weakCallback = jsEngine->StoreJsValues(values);
     std::weak_ptr<JsEngine> weakJsEngine = jsEngine;
     jsEngine->GetAsyncFileSystem()->Read(converted[0].AsString(),
       [weakJsEngine, weakCallback]
-      (std::string&& content, const std::string& error)
+      (IFileSystem::IOBuffer&& content, const std::string& error)
       {
         auto jsEngine = weakJsEngine.lock();
         if (!jsEngine)
           return;
 
         const JsContext context(*jsEngine);
         auto result = jsEngine->NewObject();
-        result.SetProperty("content", std::move(content));
+        result.SetStringBufferProperty("content", std::move(content));
         if (!error.empty())
           result.SetProperty("error", error);
         jsEngine->TakeJsValues(weakCallback)[0].Call(result);
       });
   }
 
   void WriteCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
   {
     AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arguments);
     AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments);
 
     v8::Isolate* isolate = arguments.GetIsolate();
     if (converted.size() != 3)
       return ThrowExceptionInJS(isolate, "_fileSystem.write requires 3 parameters");
     if (!converted[2].IsFunction())
       return ThrowExceptionInJS(isolate, "Third argument to _fileSystem.write must be a function");
 
     JsValueList values;
     values.push_back(converted[2]);
     auto weakCallback = jsEngine->StoreJsValues(values);
     std::weak_ptr<JsEngine> weakJsEngine = jsEngine;
+    auto content = converted[1].AsStringBuffer();
     jsEngine->GetAsyncFileSystem()->Write(converted[0].AsString(),
-      converted[1].AsString(),
+      content,
       [weakJsEngine, weakCallback](const std::string& error)
       {
         auto jsEngine = weakJsEngine.lock();
         if (!jsEngine)
           return;
 
         const JsContext context(*jsEngine);
         JsValueList params;
         if (!error.empty())
           params.push_back(jsEngine->NewValue(error));
@@ skipping 119 matching lines @@
 JsValue& FileSystemJsObject::Setup(JsEngine& jsEngine, JsValue& obj)
 {
   obj.SetProperty("read", jsEngine.NewCallback(::ReadCallback));
   obj.SetProperty("write", jsEngine.NewCallback(::WriteCallback));
   obj.SetProperty("move", jsEngine.NewCallback(::MoveCallback));
   obj.SetProperty("remove", jsEngine.NewCallback(::RemoveCallback));
   obj.SetProperty("stat", jsEngine.NewCallback(::StatCallback));
   obj.SetProperty("resolve", jsEngine.NewCallback(::ResolveCallback));
   return obj;
 }